Bug 33202

Summary: [Qt] Inconsistent DLL linkage for package builds
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 32715    
Attachments:
Description Flags
Patch vestbo: review+

Simon Hausmann
Reported 2010-01-05 01:39:59 PST
During package builds QT_MAKEDLL is not set as a define and therefore the export macros aren't set correctly. This causes build issues on Symbian and on Windows.
Attachments
Patch (1.35 KB, patch)
2010-01-05 01:41 PST, Simon Hausmann 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-01-05 01:41:24 PST
Created attachment 45874 [details] Patch
WebKit Review Bot
Comment 2 2010-01-05 01:43:40 PST
style-queue ran check-webkit-style on attachment 45874 [details] without any errors.
Simon Hausmann
Comment 3 2010-01-05 01:53:44 PST
Committed r52792: <http://trac.webkit.org/changeset/52792>
Note You need to log in before you can comment on or make changes to this bug.