Bug 33202

Summary:

[Qt] Inconsistent DLL linkage for package builds

Product:

WebKit

Reporter:

Simon Hausmann <hausmann>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

32715

Attachments:

Description	Flags
Patch	vestbo: review+

Description Simon Hausmann 2010-01-05 01:39:59 PST

During package builds QT_MAKEDLL is not set as a define and therefore the export macros aren't set correctly. This causes build issues on Symbian and on Windows.

Comment 1 Simon Hausmann 2010-01-05 01:41:24 PST

Created attachment 45874 [details]
Patch

Comment 2 WebKit Review Bot 2010-01-05 01:43:40 PST

style-queue ran check-webkit-style on attachment 45874 [details] without any errors.

Comment 3 Simon Hausmann 2010-01-05 01:53:44 PST

Committed r52792: <http://trac.webkit.org/changeset/52792>