Bug 33185

Summary:

[Chromium] Expose more DOM methods to support LayoutTests

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit API

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, webkit.review.bot, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	none
v2 patch (fixes gcc compilation error)	eric: review+, commit-queue: commit-queue-

Darin Fisher (:fishd, Google)

Reported 2010-01-04 15:40:48 PST

[Chromium] Expose more DOM methods to support LayoutTests Adding: WebDocument::documentElement() WebElement::innerText() WebFrame::renderTreeAsText() WebFrame::counterValueForElementById()

Attachments
v1 patch (7.43 KB, patch) 2010-01-04 15:44 PST, Darin Fisher (:fishd, Google)	no flags	Details Formatted Diff Diff
v2 patch (fixes gcc compilation error) (7.44 KB, patch) 2010-01-04 17:01 PST, Darin Fisher (:fishd, Google)	eric: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2010-01-04 15:44:00 PST

Created attachment 45841 [details] v1 patch

WebKit Review Bot

Comment 2 2010-01-04 15:47:09 PST

style-queue ran check-webkit-style on attachment 45841 [details] without any errors.

WebKit Review Bot

Comment 3 2010-01-04 16:25:13 PST

Attachment 45841 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/161779

Darin Fisher (:fishd, Google)

Comment 4 2010-01-04 17:01:01 PST

Created attachment 45845 [details] v2 patch (fixes gcc compilation error)

WebKit Review Bot

Comment 5 2010-01-04 17:04:28 PST

style-queue ran check-webkit-style on attachment 45845 [details] without any errors.

Eric Seidel (no email)

Comment 6 2010-01-04 21:39:20 PST

Comment on attachment 45845 [details] v2 patch (fixes gcc compilation error) Looks sane to me.

WebKit Commit Bot

Comment 7 2010-01-04 21:49:04 PST

Comment on attachment 45845 [details] v2 patch (fixes gcc compilation error) Rejecting patch 45845 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: ceeded at 443 (offset 3 lines). Hunk #6 succeeded at 467 (offset 3 lines). patching file WebKit/chromium/src/WebDocument.cpp patching file WebKit/chromium/src/WebElement.cpp Hunk #1 succeeded at 82 with fuzz 1 (offset 12 lines). patching file WebKit/chromium/src/WebFrameImpl.cpp Hunk #2 succeeded at 357 (offset 1 line). Hunk #3 succeeded at 1473 (offset 6 lines). patching file WebKit/chromium/src/WebFrameImpl.h Hunk #1 succeeded at 64 (offset 2 lines). Hunk #2 succeeded at 161 (offset 3 lines). Full output: http://webkit-commit-queue.appspot.com/results/161872

Darin Fisher (:fishd, Google)

Comment 8 2010-01-05 00:00:49 PST

Landed as http://trac.webkit.org/changeset/52788

Note You need to log in before you can comment on or make changes to this bug.