Bug 33156

Summary: [V8] Generate runtime enabler declarations currently in V8CustomBinding.h.
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32638    
Attachments:
Description Flags
patch
dglazkov: review+, japhet: commit-queue-
patch2 dglazkov: review+, japhet: commit-queue-

Nate Chapin
Reported 2010-01-04 09:10:12 PST
See summary. Most of the implementations live in V8DOMWindowCustom.cpp.
Attachments
patch (9.98 KB, patch)
2010-01-04 09:39 PST, Nate Chapin 		dglazkov: review+
japhet: commit-queue-
DetailsFormatted DiffDiff
patch2 (10.32 KB, patch)
2010-01-04 10:21 PST, Nate Chapin 		dglazkov: review+
japhet: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2010-01-04 09:39:13 PST
Created attachment 45803 [details] patch
WebKit Review Bot
Comment 2 2010-01-04 09:41:18 PST
style-queue ran check-webkit-style on attachment 45803 [details] without any errors.
Dimitri Glazkov (Google)
Comment 3 2010-01-04 09:51:33 PST
Comment on attachment 45803 [details] patch ok. Is the perhaps a way to put generation logic into its own Perl function? It doesn't seem like there is, but I thought I'd ask.
Nate Chapin
Comment 4 2010-01-04 10:21:14 PST
Created attachment 45804 [details] patch2 Perl code split into its own function.
WebKit Review Bot
Comment 5 2010-01-04 10:21:56 PST
style-queue ran check-webkit-style on attachment 45804 [details] without any errors.
Dimitri Glazkov (Google)
Comment 6 2010-01-04 10:36:21 PST
Comment on attachment 45804 [details] patch2 > +sub GenerateRuntimeEnablerDeclarations This should be GenerateHeaderRuntimeEnablerDeclarations. Or you could go with GenerateHeaderRuntimeEnabler. Can fix on landing.
Nate Chapin
Comment 7 2010-01-04 10:47:38 PST
http://trac.webkit.org/changeset/52747
Note You need to log in before you can comment on or make changes to this bug.