Bug 33127

Summary: Missing Test Outputs for MathML and License Updates
Product: WebKit Reporter: Alex Milowski <alex>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   
Attachments:
Description Flags
The patch for updating the license header and adding the test outputs none

Alex Milowski
Reported 2010-01-03 20:27:15 PST
Created attachment 45764 [details] The patch for updating the license header and adding the test outputs This patch just adds the missing tests outputs and updated the license header in preparation for other more substantial patches for MathML support.
Attachments
The patch for updating the license header and adding the test outputs (73.99 KB, patch)
2010-01-03 20:27 PST, Alex Milowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-01-03 20:28:47 PST
style-queue ran check-webkit-style on attachment 45764 [details] without any errors.
Nikolas Zimmermann
Comment 2 2010-01-03 20:32:41 PST
Comment on attachment 45764 [details] The patch for updating the license header and adding the test outputs LGTM, r=me.
Nikolas Zimmermann
Comment 3 2010-01-03 20:42:18 PST
Comment on attachment 45764 [details] The patch for updating the license header and adding the test outputs Oops, I take the r+ back. Obviously the pixel test results can't be reproduced without the actual code that renders them. So there's no point in landing it before. I got on the wrong track as the ChangeLog indicates that the pixel test results are missing, that's true, but the results that you created don't match trunk. You probably need to regenerate the results without your other patches applied (against a fresh trunk tree). Those could be landed, as they are really missing.
Alex Milowski
Comment 4 2010-01-03 20:49:59 PST
Comment on attachment 45764 [details] The patch for updating the license header and adding the test outputs The trunk can indeed generate the pixel test results. You need to turn on the MathML code by enabling it via the --mathml option on build-webkit The current trunk only supports styling via a very basic CSS stylesheet and is waiting for the rendering code. This patch reduces the size of the patch for bug 29529.
Eric Seidel (no email)
Comment 5 2010-01-04 01:38:02 PST
Comment on attachment 45764 [details] The patch for updating the license header and adding the test outputs Given that you appear to be the sole author of this code this re-license seems OK.
WebKit Commit Bot
Comment 6 2010-01-04 01:59:11 PST
Comment on attachment 45764 [details] The patch for updating the license header and adding the test outputs Clearing flags on attachment: 45764 Committed r52721: <http://trac.webkit.org/changeset/52721>
WebKit Commit Bot
Comment 7 2010-01-04 01:59:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.