Bug 33120
| Summary: | bugzilla-tool apply-patches fails with svn working directory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | abarth, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
David Kilzer (:ddkilzer)
With svn working directory:
$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
With git working directory:
$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
1 reviewed patch found on bug 33098.
Processing 1 patch from 1 bug.
Processing patch 45756 from bug 33098.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
I think this has to do with the fact that my svn working directory is a symlink:
svn co http://svn.webkit.org/repository/webkit/trunk /Volumes/Data/OpenSource
ln -s /Volumes/Data/OpenSource /Volumes/Data/WebKit
cd /Volumes/Data/WebKit
./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update
33098
David Kilzer (:ddkilzer)
(In reply to comment #1)
> I think this has to do with the fact that my svn working directory is a
> symlink:
>
> svn co http://svn.webkit.org/repository/webkit/trunk /Volumes/Data/OpenSource
> ln -s /Volumes/Data/OpenSource /Volumes/Data/WebKit
> cd /Volumes/Data/WebKit
> ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update
> 33098
Nope, this still happens when changing directory to ../OpenSource:
$ cd ../OpenSource/
$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
Adam Barth
Investigating.
Adam Barth
Works for me:
abarth@quadzen:~/svn/webkit3$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
1 reviewed patch found on bug 33098.
Processing 1 patch from 1 bug.
Processing patch 45756 from bug 33098.
Is there anything special about your webkit setup or checkout?
David Kilzer (:ddkilzer)
The immediate problem was a missing "--location" switch when using curl to download the patch, but I think WebKitTools/Scripts was stuck on an old branch. Marking RESOLVED/INVALID.