Bug 33114

Summary: [Qt] Reimplement EventSender::leapForward
Product: WebKit Reporter: Yael <yael>
Component: Tools / TestsAssignee: Yael <yael>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric, hausmann, laszlo.gombos, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 31332    
Attachments:
Description Flags
Patch.
none
Patch v2 none

Yael
Reported 2010-01-02 13:46:13 PST
The Qt implementation of EventSender::leapForward is saving the timeout value in a variable, but not waiting for that period of time. This is important for e.g. Drag & Drop tests.
Attachments
Patch. (7.65 KB, patch)
2010-01-02 14:03 PST, Yael 		no flags
DetailsFormatted DiffDiff
Patch v2 (7.80 KB, patch)
2010-01-05 07:23 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-01-02 14:03:24 PST
Created attachment 45750 [details] Patch. This is the second part of the patch aiming to fix https://bugs.webkit.org/show_bug.cgi?id=31332. It is based on the windows implementation of eventSender::leapForward.
WebKit Review Bot
Comment 2 2010-01-02 14:07:50 PST
style-queue ran check-webkit-style on attachment 45750 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-03 18:23:01 PST
I still don't really understand leapForward.
Yael
Comment 4 2010-01-05 07:23:07 PST
Created attachment 45888 [details] Patch v2 Updated the comment and renamed m_mouseButtonDown to m_mouseButtonPressed as suggested by Kenneth on IRC.
WebKit Review Bot
Comment 5 2010-01-05 07:29:22 PST
style-queue ran check-webkit-style on attachment 45888 [details] without any errors.
Kenneth Rohde Christiansen
Comment 6 2010-01-05 08:23:52 PST
Comment on attachment 45888 [details] Patch v2 Talked with Yael on IRC and she will commit a patch with some minor changes.
WebKit Commit Bot
Comment 7 2010-01-05 11:44:09 PST
Comment on attachment 45888 [details] Patch v2 Clearing flags on attachment: 45888 Committed r52816: <http://trac.webkit.org/changeset/52816>
WebKit Commit Bot
Comment 8 2010-01-05 11:44:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.