Summary: | Add #error for unsupported platforms in JITStubs.cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, commit-queue, eric, oliver, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-01-02 12:46:51 PST
Created attachment 45745 [details]
The patch (X86 and X86_64)
Attachment 45745 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:394: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1
Created attachment 45746 [details]
The patch (X86 only)
I'm not sure if the MSVC code is X86 only or X86+X86_64.
The patches are exclusive.
Attachment 45746 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:394: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1
Comment on attachment 45746 [details] The patch (X86 only) Rejecting patch 45746 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JavaScriptCore/jit/JITStubs.cpp Hunk #2 FAILED at 390. Hunk #4 FAILED at 698. 2 out of 4 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITStubs.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/161547 Created attachment 45875 [details]
The patch
Updated patch to fit the new CPU() macros.
Attachment 45875 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:400: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1
Comment on attachment 45875 [details] The patch Clearing flags on attachment: 45875 Committed r52806: <http://trac.webkit.org/changeset/52806> All reviewed patches have been landed. Closing bug. |