Bug 33112

Summary:

Add #error for unsupported platforms in JITStubs.cpp

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, eric, oliver, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
The patch (X86 and X86_64)	darin: review-
The patch (X86 only)	darin: review+, commit-queue: commit-queue-
The patch	none

Patrick R. Gansterer

Reported 2010-01-02 12:46:51 PST

see patch

Attachments
The patch (X86 and X86_64) (1.65 KB, patch) 2010-01-02 12:47 PST, Patrick R. Gansterer	darin: review-	Details Formatted Diff Diff
The patch (X86 only) (1.61 KB, patch) 2010-01-02 12:54 PST, Patrick R. Gansterer	darin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
The patch (1.58 KB, patch) 2010-01-05 02:32 PST, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2010-01-02 12:47:58 PST

Created attachment 45745 [details] The patch (X86 and X86_64)

WebKit Review Bot

Comment 2 2010-01-02 12:50:10 PST

Attachment 45745 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/jit/JITStubs.cpp:394: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1

Patrick R. Gansterer

Comment 3 2010-01-02 12:54:45 PST

Created attachment 45746 [details] The patch (X86 only) I'm not sure if the MSVC code is X86 only or X86+X86_64. The patches are exclusive.

WebKit Review Bot

Comment 4 2010-01-02 12:55:54 PST

Attachment 45746 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/jit/JITStubs.cpp:394: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1

WebKit Commit Bot

Comment 5 2010-01-04 08:24:39 PST

Comment on attachment 45746 [details] The patch (X86 only) Rejecting patch 45746 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JavaScriptCore/jit/JITStubs.cpp Hunk #2 FAILED at 390. Hunk #4 FAILED at 698. 2 out of 4 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITStubs.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/161547

Patrick R. Gansterer

Comment 6 2010-01-05 02:32:19 PST

Created attachment 45875 [details] The patch Updated patch to fit the new CPU() macros.

WebKit Review Bot

Comment 7 2010-01-05 02:34:31 PST

Attachment 45875 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/jit/JITStubs.cpp:400: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1

WebKit Commit Bot

Comment 8 2010-01-05 10:36:53 PST

Comment on attachment 45875 [details] The patch Clearing flags on attachment: 45875 Committed r52806: <http://trac.webkit.org/changeset/52806>

WebKit Commit Bot

Comment 9 2010-01-05 10:36:59 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.