| Summary: | Mark more filter effect as alphaImage if possible | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric, webkit.review.bot, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Schulze
2010-01-02 11:54:20 PST
Created attachment 45744 [details]
Mark more effects as alphaImage if previous effect is alphaImage
Mark more effects as alphaImage if previous effect is alphaImage.
style-queue ran check-webkit-style on attachment 45744 [details] without any errors.
Attachment 45744 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/159572 Created attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage
should build on qt now.
style-queue ran check-webkit-style on attachment 45751 [details] without any errors.
Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage
LGTM, r=me.
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 97.47s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/160510 Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage
The code doesn't touch anything else than SVG Filters.
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 79.05s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/161006 (In reply to comment #9) > (From update of attachment 45751 [details]) > Rejecting patch 45751 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests > Testing 11861 test cases. > fast/canvas/webgl/index-validation-copies-indices.html -> failed > > Exiting early after 1 failures. 5000 tests run. > 79.05s total testing time > > 4999 test cases (99%) succeeded > 1 test case (<1%) had incorrect layout > 1 test case (<1%) had stderr output > > Full output: http://webkit-commit-queue.appspot.com/results/161006 Hehe. There is no test with this name in the repository :-P landed in r52689. Closing bug. This patch was a victim of bug 28603. |