Bug 33107

Summary: [XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and post-from-iframe.html
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, sam, webkit.review.bot
Priority: P2 Keywords: XSSAuditor
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 33109    
Attachments:
Description Flags
Patch abarth: review+

Daniel Bates
Reported 2010-01-02 10:41:43 PST
We should remove the use of window.setTimeout from the tests: /LayoutTests/http/tests/security/xssAuditor/get-from-iframe.html /LayoutTests/http/tests/security/xssAuditor/post-from-iframe.html The JavaScript function window.setTimeout has been suspected to be the cause of test flakiness on the bots. Instead of using setTimeout we can modify the script echo-intertag.pl (called by these tests) to optionally call layoutTestController.notifyDone().
Attachments
Patch (3.39 KB, patch)
2010-01-02 10:47 PST, Daniel Bates 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-01-02 10:47:27 PST
Created attachment 45741 [details] Patch No functionality was changed, so no new tests.
WebKit Review Bot
Comment 2 2010-01-02 10:52:31 PST
style-queue ran check-webkit-style on attachment 45741 [details] without any errors.
Adam Barth
Comment 3 2010-01-02 11:27:24 PST
Comment on attachment 45741 [details] Patch excellent
Daniel Bates
Comment 4 2010-01-02 11:55:55 PST
Committed in <http://trac.webkit.org/changeset/52687>.
Note You need to log in before you can comment on or make changes to this bug.