Bug 33107

Summary:

[XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and post-from-iframe.html

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, sam, webkit.review.bot

Priority:

Keywords:

XSSAuditor

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

33109

Attachments:

Description	Flags
Patch	abarth: review+

Description Daniel Bates 2010-01-02 10:41:43 PST

We should remove the use of window.setTimeout from the tests:

/LayoutTests/http/tests/security/xssAuditor/get-from-iframe.html
/LayoutTests/http/tests/security/xssAuditor/post-from-iframe.html

The JavaScript function window.setTimeout has been suspected to be the cause of test flakiness on the bots. Instead of using setTimeout we can modify the script echo-intertag.pl (called by these tests) to optionally call layoutTestController.notifyDone().

Comment 1 Daniel Bates 2010-01-02 10:47:27 PST

Created attachment 45741 [details]
Patch

No functionality was changed, so no new tests.

Comment 2 WebKit Review Bot 2010-01-02 10:52:31 PST

style-queue ran check-webkit-style on attachment 45741 [details] without any errors.

Comment 3 Adam Barth 2010-01-02 11:27:24 PST

Comment on attachment 45741 [details]
Patch

excellent

Comment 4 Daniel Bates 2010-01-02 11:55:55 PST

Committed in <http://trac.webkit.org/changeset/52687>.