| Summary: | [Qt] Clean up File menu in QtLauncher and QGVLauncher and make keyboard shortcuts similar to Safari | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ariya.hidayat, eric, hausmann, kenneth, webkit.review.bot, zoltan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2010-01-01 15:45:53 PST
Created attachment 45736 [details]
Patch
Added a "Quit" menu option to close all open windows. Also, renamed the Tools menu to Develop to conform to the menu with the same name in Safari that contains the Show Web Inspector option.
style-queue ran check-webkit-style on attachment 45736 [details] without any errors.
Comment on attachment 45736 [details]
Patch
Looks fine by my eyes. But a Qt person should probably r+ this.
I assume that all of these QKeySequence's are available in all versions of Qt that WKQt targets? I seem to remember another patch with QKeySequence's where they were guarded or something.
Comment on attachment 45736 [details]
Patch
r+'ing this change to the test tool seems very low risk. The change looks fine to me. We can always roll this out if Dan and I both missed something.
Attachment 45736 [details] was posted by a committer and has review+, assigning to Daniel Bates for commit.
Comment on attachment 45736 [details] Patch Clearing flags on attachment: 45736 Committed r52713: <http://trac.webkit.org/changeset/52713> All reviewed patches have been landed. Closing bug. |