Bug 33097

Summary: [Qt] Clean up File menu in QtLauncher and QGVLauncher and make keyboard shortcuts similar to Safari
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, eric, hausmann, kenneth, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2010-01-01 15:45:53 PST
We should reorganize the File menu in QtLauncher and QGVLauncher as well as assign keyboard shortcuts that are similar to Safari. We should also add a "Quit" menu option that closes all open windows.
Attachments
Patch (5.75 KB, patch)
2010-01-01 15:51 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-01-01 15:51:06 PST
Created attachment 45736 [details] Patch Added a "Quit" menu option to close all open windows. Also, renamed the Tools menu to Develop to conform to the menu with the same name in Safari that contains the Show Web Inspector option.
WebKit Review Bot
Comment 2 2010-01-01 15:54:02 PST
style-queue ran check-webkit-style on attachment 45736 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-02 12:20:54 PST
Comment on attachment 45736 [details] Patch Looks fine by my eyes. But a Qt person should probably r+ this. I assume that all of these QKeySequence's are available in all versions of Qt that WKQt targets? I seem to remember another patch with QKeySequence's where they were guarded or something.
Eric Seidel (no email)
Comment 4 2010-01-03 18:16:46 PST
Comment on attachment 45736 [details] Patch r+'ing this change to the test tool seems very low risk. The change looks fine to me. We can always roll this out if Dan and I both missed something.
Eric Seidel (no email)
Comment 5 2010-01-03 18:48:14 PST
Attachment 45736 [details] was posted by a committer and has review+, assigning to Daniel Bates for commit.
Daniel Bates
Comment 6 2010-01-04 00:44:13 PST
Comment on attachment 45736 [details] Patch Clearing flags on attachment: 45736 Committed r52713: <http://trac.webkit.org/changeset/52713>
Daniel Bates
Comment 7 2010-01-04 00:44:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.