| Summary: | [V8] Separate DOMWrapperWorld from V8IsolatedWorld | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Barth
2009-12-31 10:27:55 PST
Created attachment 45717 [details]
Patch
Strange that the diff has V8IsolatedContext.* twice. My working copy seems ok though. Must be svn's way of handling renames... Created attachment 45718 [details]
Patch
Attachment 45718 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8IsolatedContext.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.cpp:64: context_scope is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/bindings/v8/V8IsolatedContext.h:36: Alphabetical sorting problem. [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:39: Alphabetical sorting problem. [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:40: One space before end of line comments [whitespace/comments] [5]
WebCore/bindings/v8/V8IsolatedContext.h:73: Use 0 instead of NULL. [readability/null] [4]
WebCore/bindings/v8/V8IsolatedContext.h:107: isolated_world is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
WebCore/bindings/v8/MainThreadDOMData.cpp:57: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 8
Created attachment 45719 [details]
Patch with style fixes
Attachment 45719 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8IsolatedContext.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.cpp:64: context_scope is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 2
Attachment 45719 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/155213 Created attachment 45720 [details]
Patch with linux build fix
This style failure seems necessary to get the patch to build on linux: readability/comparison_to_zero Attachment 45720 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
WebCore/bindings/v8/MainThreadDOMData.cpp:57: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 1
Comment on attachment 45720 [details]
Patch with linux build fix
ok. I wish this patch could've been smaller. I am pretty sure if there was a bug there somewhere, there's no way I'd see it.
Comment on attachment 45720 [details]
Patch with linux build fix
Thanks for the review. I'll try to do these changes in smaller pieces in the future.
Comment on attachment 45720 [details] Patch with linux build fix Clearing flags on attachment: 45720 Committed r52811: <http://trac.webkit.org/changeset/52811> All reviewed patches have been landed. Closing bug. |