Bug 33066

Summary: [V8] Custom callbacks aren't being declared as such
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32630    
Attachments:
Description Flags
Remove unused custom callbacks dglazkov: review+

Nate Chapin
Reported 2009-12-30 16:00:52 PST
The following callbacks have custom definitions in the v8 bindings, but are not marked as [Custom] or [V8Custom] in their respective .idl. html/canvas/WebGLByteArray : get() html/canvas/WebGLFloatArray : get() html/canvas/WebGLIntArray : get() html/canvas/WebGLShortArray : get() html/canvas/WebGLUnsignedByteArray : get() html/canvas/WebGLUnsignedIntArray : get() html/canvas/WebGLUnsignedShortArray : get() page/DOMWindow : clearInterval() page/DOMWindow : clearTimeout() xml/XMLHttpRequest : dispatchEvent() xml/XMLHttpRequestUpload : dispatchEvent() We should either mark them V8Custom or make them not need to be custom anymore.
Attachments
Remove unused custom callbacks (15.25 KB, patch)
2010-03-16 16:49 PDT, Nate Chapin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2010-01-14 10:48:23 PST
This doesn't block deleting V8CustomBinding.h, it's more general cleanup.
Nate Chapin
Comment 2 2010-03-16 16:49:11 PDT
Created attachment 50853 [details] Remove unused custom callbacks
Kenneth Russell
Comment 3 2010-03-16 17:03:02 PDT
Thanks for the cleanups to the V8WebGL*Array bindings. They look good.
Dimitri Glazkov (Google)
Comment 4 2010-03-16 17:24:14 PDT
Comment on attachment 50853 [details] Remove unused custom callbacks Marking as patch.
Dimitri Glazkov (Google)
Comment 5 2010-03-16 17:25:09 PDT
Comment on attachment 50853 [details] Remove unused custom callbacks r=me.
Nate Chapin
Comment 6 2010-03-17 10:15:14 PDT
http://trac.webkit.org/changeset/56114 and build fix in http://trac.webkit.org/changeset/56115.
Note You need to log in before you can comment on or make changes to this bug.