Bug 33058

Summary: logging.py should be renamed to webkit_logging.py and eventually die
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Eric Seidel (no email)
Reported 2009-12-30 10:14:50 PST
logging.py should be renamed to webkit_logging.py and eventually die Turns out that python has a built in logging system. Who knew? This python n00b didn't. :) Anyway, logging.py has the same import name as python's built in logging, so it needs to be renamed if we want to use python's logging. Eventually our logging module (once renamed to webkit_logging.py) should die.
Attachments
Patch (21.73 KB, patch)
2009-12-30 10:33 PST, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-30 10:17:54 PST
I'm not sure why I created a bug. Review of this kind of patch isn't very useful. But I guess I'll post it anyway.
Eric Seidel (no email)
Comment 2 2009-12-30 10:33:12 PST
Created attachment 45672 [details] Patch
Adam Barth
Comment 3 2009-12-30 10:34:25 PST
Comment on attachment 45672 [details] Patch Ok. We have a bunch of these kinds of patches to do.
Eric Seidel (no email)
Comment 4 2009-12-30 10:37:57 PST
Committed r52667: <http://trac.webkit.org/changeset/52667>
Note You need to log in before you can comment on or make changes to this bug.