Bug 33052

Summary: [Qt] http/tests/plugins/post-url-file.html failure
Product: WebKit Reporter: Jakub Wieczorek <jwieczorek>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Jakub Wieczorek 2009-12-30 05:44:31 PST 
The test fails because of the FIXME in PluginView::handlePostReadFile():
// FIXME - read the file data into buffer
Comment 1 Jakub Wieczorek 2009-12-30 05:55:09 PST 
Created attachment 45660 [details]
proposed patch

Depends on https://bugs.webkit.org/show_bug.cgi?id=33051.
Comment 2 WebKit Review Bot 2009-12-30 05:56:51 PST 
style-queue ran check-webkit-style on attachment 45660 [details] without any errors.
Comment 3 Simon Hausmann 2009-12-30 06:50:29 PST 
Comment on attachment 45660 [details]
proposed patch

r=me, nice!

Another option would be to rewrite this code to use QFile or even share an implementation across ports if possible...
Comment 4 WebKit Commit Bot 2009-12-30 06:58:39 PST 
Comment on attachment 45660 [details]
proposed patch

Clearing flags on attachment: 45660

Committed r52660: <http://trac.webkit.org/changeset/52660>
Comment 5 WebKit Commit Bot 2009-12-30 06:58:45 PST 
All reviewed patches have been landed.  Closing bug.