| Summary: | [V8] Auto-generate and split DerivedSourcesAllInOne.cpp | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yaar Schnitman <yaar> | ||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Yaar Schnitman <yaar> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bradnelson, dglazkov, dpranke, japhet, jens, jorlow, steveblock, webkit.review.bot, yaar | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | All | ||||||||||||||||||
| OS: | All | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 32630 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Yaar Schnitman
2009-12-30 03:36:51 PST
Created attachment 45651 [details]
Patch 1
This patch does the work, but depends on a necessary fix to gyp.
Opened a gyp issue: http://code.google.com/p/gyp/issues/detail?id=134 This looks awesome. I am no gyp wizard, but I have lots of ideas :) 1) I wonder if it's possible to only invoke this action when a certain condition is true? We only need this conglomeration when doing whole-program-optimization Release builds and that's an exceptional configuration, rather than the standard one. 2) It would super-great to build this as a generic conglomerator that work on any directory, like WebCore/svg and such. Is it possible? *** Bug 32128 has been marked as a duplicate of this bug. *** Yaar, any eta on getting this in? Created attachment 48951 [details]
Patch
Created attachment 49557 [details]
Patch
The file is auto-generated and split into 8 pieces, to reduce compilation units size and allow parallel compilation. Created attachment 49558 [details]
Patch
Comment on attachment 49558 [details]
Patch
Gyp changes were landed, and this is ready to go (pending review of course).
Attachment 49558 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/314039 Created attachment 49560 [details]
Patch
Comment on attachment 49560 [details]
Patch
Had to increment gyp's version on the webkit port as well.
Attachment 49560 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/313151 Created attachment 49631 [details]
Patch
Comment on attachment 49631 [details]
Patch
Ok. Please watch the canaries. They are dead at the moment.
Created attachment 50558 [details]
Delete the old DerivedSourcesAllInOne.cpp
Comment on attachment 50558 [details]
Delete the old DerivedSourcesAllInOne.cpp
ok.
|