Bug 33048

Summary:

[V8] Auto-generate and split DerivedSourcesAllInOne.cpp

Product:

WebKit

Reporter:

Yaar Schnitman <yaar>

Component:

WebKit Misc.

Assignee:

Yaar Schnitman <yaar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bradnelson, dglazkov, dpranke, japhet, jens, jorlow, steveblock, webkit.review.bot, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

32630

Attachments:

Description	Flags
Patch 1	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	dglazkov: review+
Delete the old DerivedSourcesAllInOne.cpp	dglazkov: review+

Yaar Schnitman

Reported 2009-12-30 03:36:51 PST

DerivedSourcesAllInOne.cpp is maintained manually, which is cumbersome and causes frequent chromium breakage. A new WebCore.gyp action is introduced to automatically generate this file. Chromium issue: http://code.google.com/p/chromium/issues/detail?id=16439

Attachments
Patch 1 (28.62 KB, patch) 2009-12-30 03:43 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (30.56 KB, patch) 2010-02-17 17:11 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (33.34 KB, patch) 2010-02-25 18:32 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (33.34 KB, patch) 2010-02-25 18:36 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (33.69 KB, patch) 2010-02-25 19:14 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (33.49 KB, patch) 2010-02-26 13:20 PST, Yaar Schnitman	dglazkov: review+	Details Formatted Diff Diff
Delete the old DerivedSourcesAllInOne.cpp (19.21 KB, patch) 2010-03-11 16:31 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Yaar Schnitman

Comment 1 2009-12-30 03:43:48 PST

Created attachment 45651 [details] Patch 1 This patch does the work, but depends on a necessary fix to gyp.

Yaar Schnitman

Comment 2 2009-12-30 03:53:22 PST

Opened a gyp issue: http://code.google.com/p/gyp/issues/detail?id=134

Dimitri Glazkov (Google)

Comment 3 2009-12-30 12:41:13 PST

This looks awesome. I am no gyp wizard, but I have lots of ideas :) 1) I wonder if it's possible to only invoke this action when a certain condition is true? We only need this conglomeration when doing whole-program-optimization Release builds and that's an exceptional configuration, rather than the standard one. 2) It would super-great to build this as a generic conglomerator that work on any directory, like WebCore/svg and such. Is it possible?

Dimitri Glazkov (Google)

Comment 4 2010-02-17 07:55:46 PST

*** Bug 32128 has been marked as a duplicate of this bug. ***

Jeremy Orlow

Comment 5 2010-02-17 08:02:21 PST

Yaar, any eta on getting this in?

Yaar Schnitman

Comment 6 2010-02-17 17:11:20 PST

Created attachment 48951 [details] Patch

Yaar Schnitman

Comment 7 2010-02-25 18:32:57 PST

Created attachment 49557 [details] Patch