Bug 33040

Summary: [Qt] Disable HTML DataGrid support by default
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch none

Laszlo Gombos
Reported 2009-12-29 21:14:21 PST
Apple (r52507) and than the Gtk port (r52605) disabled datagrid implementation as it is not ready for general web use yet. In general trunk is meant for development and features under development are expected to be turned on, so I'm not sure if Qt port should follow other ports as well on the trunk to turn this feature off by default. However I would propose to turn off datagrid support on the 4.6 productization branch. Patch is attached, but not put up for review as at this point this is not for trunk.
Attachments
patch (1.12 KB, patch)
2009-12-29 21:17 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-12-29 21:17:42 PST
Created attachment 45637 [details] patch
Simon Hausmann
Comment 2 2009-12-30 00:47:30 PST
Yeah, we should turn it off, the layout tests are also disabled.
Simon Hausmann
Comment 3 2009-12-30 00:48:25 PST
Committed r52648: <http://trac.webkit.org/changeset/52648>
Simon Hausmann
Comment 4 2009-12-30 00:52:54 PST
Cherry-picked into qtwebkit-4.6 as commit da94856dacd1a6a5a788def840255a6fdc1f85b7
Note You need to log in before you can comment on or make changes to this bug.