Bug 33040 - [Qt] Disable HTML DataGrid support by default
Summary: [Qt] Disable HTML DataGrid support by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-12-29 21:14 PST by Laszlo Gombos
Modified: 2009-12-30 00:52 PST (History)
1 user (show)

See Also:


Attachments
patch (1.12 KB, patch)
2009-12-29 21:17 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-12-29 21:14:21 PST
Apple (r52507) and than the Gtk port (r52605) disabled datagrid implementation as it is not ready for general web use yet. In general trunk is meant for development and features under development are expected to be turned on, so I'm not sure if Qt port should follow other ports as well on the trunk to turn this feature off by default.

However I would propose to turn off datagrid support on the 4.6 productization branch. Patch is attached, but not put up for review as at this point this is not for trunk.
Comment 1 Laszlo Gombos 2009-12-29 21:17:42 PST
Created attachment 45637 [details]
patch
Comment 2 Simon Hausmann 2009-12-30 00:47:30 PST
Yeah, we should turn it off, the layout tests are also disabled.
Comment 3 Simon Hausmann 2009-12-30 00:48:25 PST
Committed r52648: <http://trac.webkit.org/changeset/52648>
Comment 4 Simon Hausmann 2009-12-30 00:52:54 PST
Cherry-picked into qtwebkit-4.6 as commit da94856dacd1a6a5a788def840255a6fdc1f85b7