| Summary: | [check-webkit-style] Include order should understand uppercase | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2009-12-29 18:35:02 PST
Created attachment 45627 [details]
Patch
style-queue ran check-webkit-style on attachment 45627 [details] without any errors.
Comment on attachment 45627 [details]
Patch
I'm slightly confused by this. I think the sort order sorta defined to be whatever XCode's "sort lines" applescript thing does. This makes our sort order looser, which is probably good, but I'm not sure which editors will care.
Oh, we could do that. The current thing is very braindead. It thinks that capital letter always go ahead (or behind) their lowercase compatriots. Ab aa So, it wants things sorted as above, which is nonsensical to me. Our style guide says:
> Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
This patch appears to be trying to enforce case-insensitive ordering.
Comment on attachment 45627 [details]
Patch
Ah, so this patch is wrong then. I think the current behavior is wrong too, but I'll check against the "sort" command.
According to "sort", the script is currently correct. Wacky, but correct.
$ echo "aa
> Ab" | sort
Ab
aa
|