Bug 33037 – [check-webkit-style] Include order should understand uppercase

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Adam Barth]

[check-webkit-style] Include order should understand uppercase

[Adam Barth]

Created attachment 45627 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45627 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45627 [details]
Patch

I'm slightly confused by this.  I think the sort order sorta defined to be whatever XCode's "sort lines" applescript thing does.  This makes our sort order looser, which is probably good, but I'm not sure which editors will care.

[Adam Barth]

Oh, we could do that.  The current thing is very braindead.  It thinks that capital letter always go ahead (or behind) their lowercase compatriots.

Ab
aa

So, it wants things sorted as above, which is nonsensical to me.

[Mark Rowe (bdash)]

Our style guide says:

> Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).

This patch appears to be trying to enforce case-insensitive ordering.

[Adam Barth]

Comment on attachment 45627 [details]
Patch

Ah, so this patch is wrong then.  I think the current behavior is wrong too, but I'll check against the "sort" command.

[Adam Barth]

According to "sort", the script is currently correct.  Wacky, but correct.

$ echo "aa
> Ab" | sort
Ab
aa