Bug 33003

Summary: Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2009-12-28 18:43:23 PST
Warnings found in debug builds only. This patch is similar to the previously committed r42002 and r50675. List of warnings: WebCore/editing/CompositeEditCommand.cpp: In member function ‘bool WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()’: WebCore/editing/CompositeEditCommand.cpp:1093: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/page/animation/ImplicitAnimation.cpp: In member function ‘bool WebCore::ImplicitAnimation::sendTransitionEvent(const WebCore::AtomicString&, double)’: WebCore/page/animation/ImplicitAnimation.cpp:164: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/page/animation/KeyframeAnimation.cpp: In member function ‘bool WebCore::KeyframeAnimation::sendAnimationEvent(const WebCore::AtomicString&, double)’: WebCore/page/animation/KeyframeAnimation.cpp:284: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/RenderSVGContainer.h: In function ‘WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(WebCore::RenderObject*)’: WebCore/rendering/RenderSVGContainer.h:81: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/RenderSVGContainer.h: In function ‘const WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(const WebCore::RenderObject*)’: WebCore/rendering/RenderSVGContainer.h:88: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/style/RenderStyle.cpp: In member function ‘void WebCore::RenderStyle::setTextShadow(WebCore::ShadowData*, bool)’: WebCore/rendering/style/RenderStyle.cpp:705: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/svg/graphics/SVGPaintServerGradient.cpp: In member function ‘virtual bool WebCore::SVGPaintServerGradient::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’: WebCore/svg/graphics/SVGPaintServerGradient.cpp:196: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/svg/graphics/SVGPaintServerPattern.cpp: In member function ‘virtual bool WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’: WebCore/svg/graphics/SVGPaintServerPattern.cpp:106: warning: suggest parentheses around ‘&&’ within ‘||’
Attachments
proposed patch (6.43 KB, patch)
2009-12-28 18:47 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-12-28 18:47:46 PST
Created attachment 45583 [details] proposed patch
WebKit Review Bot
Comment 2 2009-12-28 18:53:21 PST
style-queue ran check-webkit-style on attachment 45583 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-28 23:58:42 PST
Comment on attachment 45583 [details] proposed patch This looks right to me.
WebKit Commit Bot
Comment 4 2009-12-29 05:22:06 PST
Comment on attachment 45583 [details] proposed patch Clearing flags on attachment: 45583 Committed r52618: <http://trac.webkit.org/changeset/52618>
WebKit Commit Bot
Comment 5 2009-12-29 05:22:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.