Bug 32975

Summary:

[check-webkit-style] does understand ResourceHandleWin.h

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, eric, hamaji, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Adam Barth 2009-12-27 18:10:10 PST

Comment #4 From Patrick R. Gansterer 2009-12-27 10:48:12 PST (-) [reply] 
(In reply to comment #2)
> WebCore/platform/network/win/ResourceHandleWin.cpp:38:  Found header this file
> implements after other header. Should be: config.h, primary header, blank line,
> and then alphabetically sorted.  [build/include_order] [4]

The primary header header is ResourceHandle.h. ResourceHandleWin.h is only an
ugly helperfile.

https://bugs.webkit.org/show_bug.cgi?id=32963#c4

Comment 1 Adam Barth 2010-01-17 16:15:07 PST

Created attachment 46768 [details]
Patch

Comment 2 Shinichiro Hamaji 2010-01-17 17:29:13 PST

Comment on attachment 46768 [details]
Patch

> +            # Thus far, we've only seen one example of these, but if we start
> +            # to see more, please consider abstracting this check somehow.

Using FIXME would be better?

Comment 3 Adam Barth 2010-01-18 01:11:15 PST

Created attachment 46798 [details]
Patch for landing

Comment 4 Adam Barth 2010-01-18 02:13:10 PST

Comment on attachment 46798 [details]
Patch for landing

Clearing flags on attachment: 46798

Committed r53398: <http://trac.webkit.org/changeset/53398>

Comment 5 Adam Barth 2010-01-18 02:13:18 PST

All reviewed patches have been landed.  Closing bug.