[bzt] Update unit test to check for added --makeargs="-j8" command-line argument

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

In the patch for bug #32951, the command-line argument --makeargs="-j8" was added to the build-webkit command. However, the associated unit test was not updated.

For reference, the error message output by run-webkit-unittests is:

======================================================================
FAIL: test_qt_port (modules.webkitport_unittest.WebKitPortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/modules/webkitport_unittest.py", line 51, in test_qt_port
    self.assertEquals(QtPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--qt"])
AssertionError: ['WebKitTools/Scripts/build-webkit', '--qt', '--makeargs="-j8"'] != ['WebKitTools/Scripts/build-webkit', '--qt']

[Daniel Bates]

Created attachment 45526 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45526 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45526 [details]
Patch

Eseidel and abarth fail. We need to make the commit queue call run-webkit-unittests

[Daniel Bates]

Committed in <http://trac.webkit.org/changeset/52582>.