Bug 32964 - [bzt] Update unit test to check for added --makeargs="-j8" command-line argument
Summary: [bzt] Update unit test to check for added --makeargs="-j8" command-line argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-27 10:59 PST by Daniel Bates
Modified: 2009-12-27 11:13 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2009-12-27 11:01 PST, Daniel Bates
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-12-27 10:59:49 PST
In the patch for bug #32951, the command-line argument --makeargs="-j8" was added to the build-webkit command. However, the associated unit test was not updated.

For reference, the error message output by run-webkit-unittests is:

======================================================================
FAIL: test_qt_port (modules.webkitport_unittest.WebKitPortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/modules/webkitport_unittest.py", line 51, in test_qt_port
    self.assertEquals(QtPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--qt"])
AssertionError: ['WebKitTools/Scripts/build-webkit', '--qt', '--makeargs="-j8"'] != ['WebKitTools/Scripts/build-webkit', '--qt']
Comment 1 Daniel Bates 2009-12-27 11:01:25 PST
Created attachment 45526 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-27 11:03:32 PST
style-queue ran check-webkit-style on attachment 45526 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-27 11:09:19 PST
Comment on attachment 45526 [details]
Patch

Eseidel and abarth fail. We need to make the commit queue call run-webkit-unittests
Comment 4 Daniel Bates 2009-12-27 11:13:42 PST
Committed in <http://trac.webkit.org/changeset/52582>.