WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32964
[bzt] Update unit test to check for added --makeargs="-j8" command-line argument
https://bugs.webkit.org/show_bug.cgi?id=32964
Summary
[bzt] Update unit test to check for added --makeargs="-j8" command-line argument
Daniel Bates
Reported
2009-12-27 10:59:49 PST
In the patch for
bug #32951
, the command-line argument --makeargs="-j8" was added to the build-webkit command. However, the associated unit test was not updated. For reference, the error message output by run-webkit-unittests is: ====================================================================== FAIL: test_qt_port (modules.webkitport_unittest.WebKitPortTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/modules/webkitport_unittest.py", line 51, in test_qt_port self.assertEquals(QtPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--qt"]) AssertionError: ['WebKitTools/Scripts/build-webkit', '--qt', '--makeargs="-j8"'] != ['WebKitTools/Scripts/build-webkit', '--qt']
Attachments
Patch
(1.58 KB, patch)
2009-12-27 11:01 PST
,
Daniel Bates
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2009-12-27 11:01:25 PST
Created
attachment 45526
[details]
Patch
WebKit Review Bot
Comment 2
2009-12-27 11:03:32 PST
style-queue ran check-webkit-style on
attachment 45526
[details]
without any errors.
Eric Seidel (no email)
Comment 3
2009-12-27 11:09:19 PST
Comment on
attachment 45526
[details]
Patch Eseidel and abarth fail. We need to make the commit queue call run-webkit-unittests
Daniel Bates
Comment 4
2009-12-27 11:13:42 PST
Committed in <
http://trac.webkit.org/changeset/52582
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug