Bug 32907

Summary:

Cleanup of #define JS_EXPORT

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, commit-queue, eric, sfalken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Cleanup of #define JS_EXPORT	none

Patrick R. Gansterer

Reported 2009-12-23 11:02:05 PST

Created attachment 45442 [details] Cleanup of #define JS_EXPORT Merged the WinCE part into the general Windows part.

Attachments
Cleanup of #define JS_EXPORT (2.69 KB, patch) 2009-12-23 11:02 PST, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2009-12-23 11:07:17 PST

style-queue ran check-webkit-style on attachment 45442 [details] without any errors.

Maciej Stachowiak

Comment 2 2009-12-28 02:09:03 PST

Comment on attachment 45442 [details] Cleanup of #define JS_EXPORT r=me but make sure to watch the bots when landing this or otherwise verify that other ports will still build.

Eric Seidel (no email)

Comment 3 2009-12-28 08:39:38 PST

Comment on attachment 45442 [details] Cleanup of #define JS_EXPORT Well, the EWS says that Chromium and Qt still build with this (https://webkit-commit-queue.appspot.com/patch/45442), and the commit-queue will check Leopard Release, so I think this is safe to commit. I'll roll it out if it breaks stuff.

WebKit Commit Bot

Comment 4 2009-12-28 08:58:39 PST

Comment on attachment 45442 [details] Cleanup of #define JS_EXPORT Clearing flags on attachment: 45442 Committed r52598: <http://trac.webkit.org/changeset/52598>

WebKit Commit Bot

Comment 5 2009-12-28 08:58:44 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.