Bug 32858

Summary: check-webkit-style should not warn about NULL usage in g_object_{get,set}
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, eric, hamaji, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
proposed patch none

Description Philippe Normand 2009-12-22 01:12:37 PST
If those 2 functions are called with 0 instead of NULL the compiler warns:

warning: missing sentinel in function call
Comment 1 Philippe Normand 2009-12-22 01:41:20 PST
Created attachment 45375 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-22 01:43:18 PST
style-queue ran check-webkit-style on attachment 45375 [details] without any errors.
Comment 3 Adam Barth 2009-12-22 13:09:25 PST
Comment on attachment 45375 [details]
proposed patch

Thanks for quashing this false positive.
Comment 4 WebKit Commit Bot 2009-12-22 13:18:57 PST
Comment on attachment 45375 [details]
proposed patch

Clearing flags on attachment: 45375

Committed r52496: <http://trac.webkit.org/changeset/52496>
Comment 5 WebKit Commit Bot 2009-12-22 13:19:02 PST
All reviewed patches have been landed.  Closing bug.