Bug 32853

Summary: Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Use __forceinline to force RVCT to inline functions. none

Kwang Yul Seo
Reported 2009-12-21 23:33:25 PST
In RVCT, __forceinline forces the compiler to compile a C or C++ function inline. The compiler attempts to inline the function, regardless of the characteristics of the function. I see no real performance gains in SunSpider after applying this patch, but I think being explicit about the intention is good.
Attachments
Use __forceinline to force RVCT to inline functions. (1.91 KB, patch)
2009-12-21 23:36 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2009-12-21 23:36:41 PST
Created attachment 45367 [details] Use __forceinline to force RVCT to inline functions.
WebKit Review Bot
Comment 2 2009-12-21 23:40:39 PST
Attachment 45367 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/AlwaysInline.h:26: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1
WebKit Commit Bot
Comment 3 2009-12-22 10:36:48 PST
Comment on attachment 45367 [details] Use __forceinline to force RVCT to inline functions. Clearing flags on attachment: 45367 Committed r52490: <http://trac.webkit.org/changeset/52490>
WebKit Commit Bot
Comment 4 2009-12-22 10:36:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.