Bug 32841

Summary:

[Chromium] Adding new methods to the Chromium DOM API

Product:

WebKit

Reporter:

Jay Campan <jcampan>

Component:

WebKit API

Assignee:

Jay Campan <jcampan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dglazkov, eric, fishd, mjs, vasubharani96, webkit.review.bot, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Adding some extra methods to the Chromium DOM API (needed for the translate feature)	none
45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature)	fishd: review-
Changed WebElement::getTagName() to WebElement::tagName()	none
Changed WebElement::getTagName() to WebElement::tagName()	none

Jay Campan

Reported 2009-12-21 14:50:17 PST

Created attachment 45350 [details] Adding some extra methods to the Chromium DOM API (needed for the translate feature) Adding new methods to the Chromium DOM API. There are needed by the upcoming translate feature.

Attachments
Adding some extra methods to the Chromium DOM API (needed for the translate feature) (4.77 KB, patch) 2009-12-21 14:50 PST, Jay Campan	no flags	Details Formatted Diff Diff
45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature) (4.19 KB, patch) 2009-12-22 09:18 PST, Jay Campan	fishd: review-	Details Formatted Diff Diff
Changed WebElement::getTagName() to WebElement::tagName() (4.16 KB, application/octet-stream) 2010-01-04 12:01 PST, Jay Campan	no flags	Details
Changed WebElement::getTagName() to WebElement::tagName() (4.16 KB, patch) 2010-01-04 12:02 PST, Jay Campan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2009-12-21 14:50:42 PST

Attachment 45350 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebNode.cpp:90: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1

Eric Seidel (no email)

Comment 2 2009-12-21 21:49:04 PST

Darin or Dimitry is your best bet. Also there is a style error in the patch.

Jay Campan

Comment 3 2009-12-22 09:18:21 PST

Created attachment 45389 [details] 45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature) Fixing style issue.

WebKit Review Bot

Comment 4 2009-12-22 09:21:25 PST

style-queue ran check-webkit-style on attachment 45389 [details] without any errors.

Adam Barth

Comment 5 2009-12-22 09:55:54 PST

Looks sane to me, but Darin is the arbiter of the API.

Darin Fisher (:fishd, Google)

Comment 6 2010-01-04 11:03:48 PST

Comment on attachment 45389 [details] 45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature) > Index: WebKit/chromium/src/WebElement.cpp ... > +WebString WebElement::getTagName() const > +{ > + return constUnwrap<Element>()->tagName(); Please change WebElement::getTagName to just tagName. WebKit style avoids "get" Otherwise, LGTM -Darin

Jay Campan

Comment 7 2010-01-04 12:01:26 PST

Created attachment 45812 [details] Changed WebElement::getTagName() to WebElement::tagName()

Jay Campan

Comment 8 2010-01-04 12:02:23 PST

Created attachment 45813 [details] Changed WebElement::getTagName() to WebElement::tagName()

WebKit Commit Bot

Comment 9 2010-01-04 17:12:31 PST

Comment on attachment 45813 [details] Changed WebElement::getTagName() to WebElement::tagName() Clearing flags on attachment: 45813 Committed r52774: <http://trac.webkit.org/changeset/52774>

WebKit Commit Bot

Comment 10 2010-01-04 17:12:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.