Summary: | [Chromium] Adding new methods to the Chromium DOM API | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jay Campan <jcampan> |
Component: | WebKit API | Assignee: | Jay Campan <jcampan> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, fishd, mjs, vasubharani96, webkit.review.bot, yaar |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 | ||
Attachments: |
Attachment 45350 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebNode.cpp:90: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1
Darin or Dimitry is your best bet. Also there is a style error in the patch. Created attachment 45389 [details]
45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature)
Fixing style issue.
style-queue ran check-webkit-style on attachment 45389 [details] without any errors.
Looks sane to me, but Darin is the arbiter of the API. Comment on attachment 45389 [details] 45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature) > Index: WebKit/chromium/src/WebElement.cpp ... > +WebString WebElement::getTagName() const > +{ > + return constUnwrap<Element>()->tagName(); Please change WebElement::getTagName to just tagName. WebKit style avoids "get" Otherwise, LGTM -Darin Created attachment 45812 [details]
Changed WebElement::getTagName() to WebElement::tagName()
Created attachment 45813 [details]
Changed WebElement::getTagName() to WebElement::tagName()
Comment on attachment 45813 [details] Changed WebElement::getTagName() to WebElement::tagName() Clearing flags on attachment: 45813 Committed r52774: <http://trac.webkit.org/changeset/52774> All reviewed patches have been landed. Closing bug. |
Created attachment 45350 [details] Adding some extra methods to the Chromium DOM API (needed for the translate feature) Adding new methods to the Chromium DOM API. There are needed by the upcoming translate feature.