Bug 32820

Summary:

check-webkit-style fails if Git is configured with diff.mnemonicprefix

Product:

WebKit

Reporter:

Tor Arne Vestbø <vestbo>

Component:

Tools / Tests

Assignee:

Tor Arne Vestbø <vestbo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, ddkilzer, eric, hamaji, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option	none
check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option	none
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools	none
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools	none
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools	none
Updated ChangeLog to reflect new path for python files	none
Move perl-unit-test to new webkitperl subdir per r52733	ddkilzer: review+, ddkilzer: commit-queue-

Tor Arne Vestbø

Reported 2009-12-21 04:11:32 PST

The regex in WebKitTools/Scripts/modules/diff_parser.py expects a/filname b/filname format

Attachments
check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option (1.74 KB, patch) 2009-12-21 04:12 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option (2.28 KB, patch) 2009-12-21 04:13 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools (6.08 KB, patch) 2010-01-04 01:37 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools (6.08 KB, patch) 2010-01-04 01:41 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools (8.35 KB, patch) 2010-01-04 03:10 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
Updated ChangeLog to reflect new path for python files (8.36 KB, patch) 2010-01-04 03:19 PST, Tor Arne Vestbø	no flags	Details Formatted Diff Diff
Move perl-unit-test to new webkitperl subdir per r52733 (10.27 KB, patch) 2010-01-04 07:39 PST, Tor Arne Vestbø	ddkilzer: review+ ddkilzer: commit-queue-	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Tor Arne Vestbø

Comment 1 2009-12-21 04:12:15 PST

Created attachment 45320 [details] check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option

Tor Arne Vestbø

Comment 2 2009-12-21 04:13:53 PST

Created attachment 45321 [details] check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option

WebKit Review Bot

Comment 3 2009-12-21 04:16:22 PST

style-queue ran check-webkit-style on attachment 45321 [details] without any errors.

Eric Seidel (no email)

Comment 4 2009-12-21 21:51:32 PST

Comment on attachment 45321 [details] check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option I expect other tools, like svn-apply (seen VCSTools.pm) will have trouble with this git setting as well. This change is in our python code and requires a unit test.

Tor Arne Vestbø

Comment 5 2010-01-04 01:37:55 PST

Created attachment 45783 [details] Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Eric Seidel (no email)

Comment 6 2010-01-04 01:40:50 PST

VCSTools also has unit tests now, seems we should add a unit test for the perl code as well.

Tor Arne Vestbø

Comment 7 2010-01-04 01:41:19 PST

Created attachment 45785 [details] Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Chris Jerdonek

Comment 8 2010-01-04 01:56:41 PST

(In reply to comment #6) > VCSTools also has unit tests now, seems we should add a unit test for the perl > code as well. That sounds like a good idea. I would wait until the following patch lands, though, so the new unit test directory structure can be used for the new test: https://bugs.webkit.org/show_bug.cgi?id=33124 The VCSUtils.pm portion of the test may also assist me in coming up with unit test cases for this: https://bugs.webkit.org/show_bug.cgi?id=33134

WebKit Review Bot

Comment 9 2010-01-04 02:52:56 PST

style-queue ran check-webkit-style on attachment 45785 [details] without any errors.

Tor Arne Vestbø

Comment 10 2010-01-04 03:10:42 PST

Created attachment 45792 [details] Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Tor Arne Vestbø

Comment 11 2010-01-04 03:12:15 PST

Added unit-test for VCUtils' gitdiff2svndiff I'll update the patch when 33124 gets landed if this one hasn't landed yet.

WebKit Review Bot

Comment 12 2010-01-04 03:14:18 PST

style-queue ran check-webkit-style on attachment 45792 [details] without any errors.

Tor Arne Vestbø

Comment 13 2010-01-04 03:19:58 PST

Created attachment 45794 [details] Updated ChangeLog to reflect new path for python files

WebKit Review Bot

Comment 14 2010-01-04 03:25:11 PST

style-queue ran check-webkit-style on attachment 45794 [details] without any errors.

Tor Arne Vestbø

Comment 15 2010-01-04 07:39:00 PST

Created attachment 45800 [details] Move perl-unit-test to new webkitperl subdir per r52733

WebKit Review Bot

Comment 16 2010-01-04 07:39:31 PST

style-queue ran check-webkit-style on attachment 45800 [details] without any errors.

David Kilzer (:ddkilzer)

Comment 17 2010-01-04 07:59:40 PST

Comment on attachment 45800 [details] Move perl-unit-test to new webkitperl subdir per r52733 > diff --git a/WebKitTools/Scripts/test-webkitperl b/WebKitTools/Scripts/test-webkitperl > @@ -44,6 +44,7 @@ my @files = ( > "fixChangeLogPatch.pl", > "generatePatchCommand.pl", > "runPatchCommand.pl", > + "gitdiff2svndiff.pl", > ); Nit: I would prefer these in alphabetic order. r=me

Tor Arne Vestbø

Comment 18 2010-01-04 08:13:23 PST

Landed in r52739, with nit fixed :) Thanks David!

Note You need to log in before you can comment on or make changes to this bug.