Bug 32817

Summary:

[Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agl, brettw, commit-queue, eric, krit, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.	none

Description Yuta Kitamura 2009-12-21 00:43:50 PST

PlatformContextSkia::beginLayerClippedToImage is supposed to limit the current painting window to the bounds of the given image, but it does not. This makes LayoutTests/svg/custom/mask-with-all-units.svg fail in the Chromium layout test.

Chromium issue: http://code.google.com/p/chromium/issues/detail?id=29056

Comment 1 Yuta Kitamura 2009-12-21 01:18:15 PST

Created attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

Comment 2 WebKit Review Bot 2009-12-21 01:21:49 PST

style-queue ran check-webkit-style on attachment 45314 [details] without any errors.

Comment 3 Adam Langley 2009-12-23 16:26:50 PST

LGTM.

(I am not a WebKit reviewer. You need a real review before landing.)

Comment 4 Eric Seidel (no email) 2009-12-23 16:36:49 PST

Comment on attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

Thank you Adam.  LGTM too.

Comment 5 WebKit Commit Bot 2009-12-23 18:23:48 PST

Comment on attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

Clearing flags on attachment: 45314

Committed r52539: <http://trac.webkit.org/changeset/52539>

Comment 6 WebKit Commit Bot 2009-12-23 18:23:54 PST

All reviewed patches have been landed.  Closing bug.