Bug 32796

Summary:

[check-webkit-style] static_cast is not misnamed!

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, commit-queue, eric, hamaji, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none

Description Adam Barth 2009-12-20 09:47:28 PST

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/qt/ThreadingQt.cpp:183:  static_cast is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1

https://bugs.webkit.org/show_bug.cgi?id=32614#c2

Comment 1 Shinichiro Hamaji 2009-12-20 10:02:41 PST

Created attachment 45285 [details]
Patch v1

Comment 2 WebKit Review Bot 2009-12-20 10:04:16 PST

style-queue ran check-webkit-style on attachment 45285 [details] without any errors.

Comment 3 Adam Barth 2009-12-20 10:14:19 PST

Comment on attachment 45285 [details]
Patch v1

LGTM!

Comment 4 WebKit Commit Bot 2009-12-20 10:22:19 PST

Comment on attachment 45285 [details]
Patch v1

Clearing flags on attachment: 45285

Committed r52423: <http://trac.webkit.org/changeset/52423>

Comment 5 WebKit Commit Bot 2009-12-20 10:22:25 PST

All reviewed patches have been landed.  Closing bug.