Summary: | [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Alejandro G. Castro
2009-12-20 03:57:04 PST
Created attachment 45269 [details]
Proposed patch
Added fixed font size.
style-queue ran check-webkit-style on attachment 45269 [details] without any errors.
Comment on attachment 45269 [details]
Proposed patch
Looks good (and works for me).
Comment on attachment 45269 [details] Proposed patch Clearing flags on attachment: 45269 Committed r52413: <http://trac.webkit.org/changeset/52413> All reviewed patches have been landed. Closing bug. This fix does not fix the problem, we have to create a test that does not use fixed values for the events positions. Created attachment 45275 [details]
Proposed patch
Avoid using fixed mouse positions, it was causing problems in the bots, and add button to the click count function to avoid double paste with different buttons.
style-queue ran check-webkit-style on attachment 45275 [details] without any errors.
Created attachment 45278 [details]
Proposed patch
Small nitpick.
style-queue ran check-webkit-style on attachment 45278 [details] without any errors.
Comment on attachment 45278 [details]
Proposed patch
This should work better, thanks =). Tested locally, let's see if the bots like it.
Comment on attachment 45278 [details] Proposed patch Clearing flags on attachment: 45278 Committed r52419: <http://trac.webkit.org/changeset/52419> All reviewed patches have been landed. Closing bug. |