Summary: | upstream several platform-specific chromium plugin tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, commit-queue, eric, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2009-12-18 16:04:29 PST
Created attachment 45198 [details]
Patch
style-queue ran check-webkit-style on attachment 45198 [details] without any errors.
OK. Should be easy enough to add to DumpRenderTree eventually as well. Comment on attachment 45198 [details] Patch Rejecting patch 45198 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tform/chromium/plugins' is not a file The following files contain tab characters: trunk/LayoutTests/platform/chromium/plugins/multiple-plugins.html trunk/LayoutTests/platform/chromium/plugins/nested-plugin-objects.html trunk/LayoutTests/platform/chromium/plugins/refcount-leaks.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/136250 Created attachment 45352 [details]
Patch
submitted revised patch with tabs removed. style-queue ran check-webkit-style on attachment 45352 [details] without any errors.
Comment on attachment 45352 [details] Patch Clearing flags on attachment: 45352 Committed r52462: <http://trac.webkit.org/changeset/52462> All reviewed patches have been landed. Closing bug. |