Bug 32751

Summary: upstream several platform-specific chromium plugin tests
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Dirk Pranke
Reported 2009-12-18 16:04:29 PST
upstreaming a few platform-specific tests from chromium.org. Most of these rely on features that have been added to the chromium port of the test plugin that we will need to upstream when we upstream our revised DumpRenderTree/TestShell driver.
Attachments
Patch (17.34 KB, patch)
2009-12-18 16:05 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (17.30 KB, patch)
2009-12-21 14:59 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2009-12-18 16:05:29 PST
Created attachment 45198 [details] Patch
WebKit Review Bot
Comment 2 2009-12-18 16:06:45 PST
style-queue ran check-webkit-style on attachment 45198 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-19 12:08:30 PST
OK. Should be easy enough to add to DumpRenderTree eventually as well.
WebKit Commit Bot
Comment 4 2009-12-20 02:35:44 PST
Comment on attachment 45198 [details] Patch Rejecting patch 45198 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tform/chromium/plugins' is not a file The following files contain tab characters: trunk/LayoutTests/platform/chromium/plugins/multiple-plugins.html trunk/LayoutTests/platform/chromium/plugins/nested-plugin-objects.html trunk/LayoutTests/platform/chromium/plugins/refcount-leaks.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/136250
Dirk Pranke
Comment 5 2009-12-21 14:59:44 PST
Created attachment 45352 [details] Patch
Dirk Pranke
Comment 6 2009-12-21 15:00:20 PST
submitted revised patch with tabs removed.
WebKit Review Bot
Comment 7 2009-12-21 15:01:15 PST
style-queue ran check-webkit-style on attachment 45352 [details] without any errors.
WebKit Commit Bot
Comment 8 2009-12-21 15:50:09 PST
Comment on attachment 45352 [details] Patch Clearing flags on attachment: 45352 Committed r52462: <http://trac.webkit.org/changeset/52462>
WebKit Commit Bot
Comment 9 2009-12-21 15:50:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.