Bug 32732
| Summary: | addition of setTouchMocking breaks builds with Qt < 4.6.0 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Kyzivat <kamaji> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Blocker | CC: | ariya.hidayat |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Keith Kyzivat
When compiling svn 52312 for Qt under Linux with Qt 4.5.0, I received the following compilation error:
Creating hashtable for ../../../JavaScriptCore/runtime/StringPrototype.cpp
In file included from /home/kyzivat/builds/WebKit/WebKit/qt/QtLauncher/main.cpp:702:
./main.moc: In member function ‘virtual int MainWindow::qt_metacall(QMetaObject::Call, int, void**)’:
./main.moc:215: error: ‘setTouchMocking’ was not declared in this scope
make[1]: *** [main.o] Error 1
make: *** [sub-WebKit-qt-QtLauncher-make_default-ordered] Error 2
Looking at WebKit/qt/QtLauncher/main.cpp, I see that setTouchMocking is only included if Qt version is >= 4.6.0.
Thus, in my environment, it would not include setTouchMocking implementation.
When Qt builds main.moc, it seems not to honor the #ifdef directive, and erroneously creates binding for setTouchMocking.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Keith Kyzivat
Forgot to mention -- this change was introduced with changeset [52250]
Ariya Hidayat
Fixed in r52340
http://trac.webkit.org/changeset/52340