Summary: | Allow custom memory allocation control for inspector's classes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Zoltan Horvath
2009-12-17 07:06:02 PST
Created attachment 45063 [details]
proposed patch
style-queue ran check-webkit-style on attachment 45063 [details] without any errors.
Comment on attachment 45063 [details] proposed patch > - class JavaScriptDebugServer : JSC::Debugger { > + class JavaScriptDebugServer : JSC::Debugger, public Noncopyable { I think it would be better to change DEFINE_STATIC_LOCAL to use fastNew rather than changing all the classes using it to inherit from Noncopyable and FastAllocBase. I'm not sure why I didn't think of this earlier. r=me on this, but it seems it would be worthwhile to do that Comment on attachment 45063 [details] proposed patch Clearing flags on attachment: 45063 Committed r52294: <http://trac.webkit.org/changeset/52294> All reviewed patches have been landed. Closing bug. |