Bug 32617 – [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[anton muhin]

Currently Node.cpp doesn't compile at least MSVC 8 as a part of Chromium project.  Let's fix it.

[anton muhin]

Created attachment 44988 [details]
First take

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44988 [details] without any errors.

[Darin Adler]

Comment on attachment 44988 [details]
First take

Seems OK, r=me

[anton muhin]

Comment on attachment 44988 [details]
First take

Thanks a lot for review, Darin.

[WebKit Commit Bot]

Comment on attachment 44988 [details]
First take

Rejecting patch 44988 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11779 test cases.
fast/profiler/stop-profiling-after-setTimeout.html -> crashed

Exiting early after 1 failures. 7790 tests run.
257.70s total testing time

7789 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/127624

[anton muhin]

(In reply to comment #5)
> (From update of attachment 44988 [details])
> Rejecting patch 44988 from commit-queue.
> 
> Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari',
> '--exit-after-n-failures=1', '--quiet']" exit_code: 1
> Running build-dumprendertree
> Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
> Testing 11779 test cases.
> fast/profiler/stop-profiling-after-setTimeout.html -> crashed
> 
> Exiting early after 1 failures. 7790 tests run.
> 257.70s total testing time
> 
> 7789 test cases (99%) succeeded
> 1 test case (<1%) crashed
> 3 test cases (<1%) had stderr output
> 
> Full output: http://webkit-commit-queue.appspot.com/results/127624

Is there a way to see full output?  I am somewhat sceptical that my change could have cause this as modulo another include altered code is most probably is not compiled at all.

[Zoltan Horvath]

Comment on attachment 44988 [details]
First take

It's okay on my system. Let's try it again with the bot.

[anton muhin]

(In reply to comment #7)
> (From update of attachment 44988 [details])
> It's okay on my system. Let's try it again with the bot.

Thanks a lot, Zlotan.

[WebKit Commit Bot]

Comment on attachment 44988 [details]
First take

Clearing flags on attachment: 44988

Committed r52212: <http://trac.webkit.org/changeset/52212>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Zoltan Horvath]

Patch is committed :)
In the future feel free to CCing me!

[Eric Seidel (no email)]

Filed bug 32643 about the flakey test.