Bug 32617 - [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
: [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-16 10:03 PST by anton muhin
Modified: 2009-12-16 17:49 PST (History)
4 users (show)

See Also:


Attachments
First take (1.69 KB, patch)
2009-12-16 10:05 PST, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2009-12-16 10:03:03 PST
Currently Node.cpp doesn't compile at least MSVC 8 as a part of Chromium project.  Let's fix it.
Comment 1 anton muhin 2009-12-16 10:05:16 PST
Created attachment 44988 [details]
First take
Comment 2 WebKit Review Bot 2009-12-16 10:07:55 PST
style-queue ran check-webkit-style on attachment 44988 [details] without any errors.
Comment 3 Darin Adler 2009-12-16 10:14:23 PST
Comment on attachment 44988 [details]
First take

Seems OK, r=me
Comment 4 anton muhin 2009-12-16 10:18:48 PST
Comment on attachment 44988 [details]
First take

Thanks a lot for review, Darin.
Comment 5 WebKit Commit Bot 2009-12-16 10:35:38 PST
Comment on attachment 44988 [details]
First take

Rejecting patch 44988 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11779 test cases.
fast/profiler/stop-profiling-after-setTimeout.html -> crashed

Exiting early after 1 failures. 7790 tests run.
257.70s total testing time

7789 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/127624
Comment 6 anton muhin 2009-12-16 10:38:13 PST
(In reply to comment #5)
> (From update of attachment 44988 [details])
> Rejecting patch 44988 from commit-queue.
> 
> Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari',
> '--exit-after-n-failures=1', '--quiet']" exit_code: 1
> Running build-dumprendertree
> Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
> Testing 11779 test cases.
> fast/profiler/stop-profiling-after-setTimeout.html -> crashed
> 
> Exiting early after 1 failures. 7790 tests run.
> 257.70s total testing time
> 
> 7789 test cases (99%) succeeded
> 1 test case (<1%) crashed
> 3 test cases (<1%) had stderr output
> 
> Full output: http://webkit-commit-queue.appspot.com/results/127624

Is there a way to see full output?  I am somewhat sceptical that my change could have cause this as modulo another include altered code is most probably is not compiled at all.
Comment 7 Zoltan Horvath 2009-12-16 11:16:29 PST
Comment on attachment 44988 [details]
First take

It's okay on my system. Let's try it again with the bot.
Comment 8 anton muhin 2009-12-16 11:27:24 PST
(In reply to comment #7)
> (From update of attachment 44988 [details])
> It's okay on my system. Let's try it again with the bot.

Thanks a lot, Zlotan.
Comment 9 WebKit Commit Bot 2009-12-16 11:34:08 PST
Comment on attachment 44988 [details]
First take

Clearing flags on attachment: 44988

Committed r52212: <http://trac.webkit.org/changeset/52212>
Comment 10 WebKit Commit Bot 2009-12-16 11:34:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Zoltan Horvath 2009-12-16 11:36:29 PST
Patch is committed :)
In the future feel free to CCing me!
Comment 12 Eric Seidel 2009-12-16 17:49:34 PST
Filed bug 32643 about the flakey test.