Bug 32609

Summary: Web Inspector: Make Elements tree, properties section and resources view monospace.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Screen 1
none
[IMAGE] Screen 2
none
[PATCH] Proposed change.
none
[PATCH] Same with fix for windows platform and console prompt.
timothy: review+
[IMAGE] Win / Chromium looks none

Description Pavel Feldman 2009-12-16 06:38:08 PST 
Created attachment 44970 [details]
[IMAGE] Screen 1

See screenshots attached.
Comment 1 Pavel Feldman 2009-12-16 06:38:38 PST 
Created attachment 44971 [details]
[IMAGE] Screen 2
Comment 2 Pavel Feldman 2009-12-16 06:42:21 PST 
Created attachment 44972 [details]
[PATCH] Proposed change.
Comment 3 WebKit Review Bot 2009-12-16 06:47:28 PST 
style-queue ran check-webkit-style on attachment 44972 [details] without any errors.
Comment 4 Pavel Feldman 2009-12-16 07:08:40 PST 
Created attachment 44974 [details]
[PATCH] Same with fix for windows platform and console prompt.
Comment 5 WebKit Review Bot 2009-12-16 07:13:12 PST 
style-queue ran check-webkit-style on attachment 44974 [details] without any errors.
Comment 6 Pavel Feldman 2009-12-16 07:28:34 PST 
Created attachment 44976 [details]
[IMAGE] Win / Chromium looks
Comment 7 Timothy Hatcher 2009-12-16 09:45:42 PST 
Comment on attachment 44974 [details]
[PATCH] Same with fix for windows platform and console prompt.


> +                span.addStyleClass("console-formatted-trace source code");

Should be source-code.


> +    white-space: pre;

This should be pre-wrap, pre is pretty dangerous.


> +    font-family: Monaco, monospace;

Some people are going to ask for Menlo on Snow Leopard… But alti-alias monospace is pretty bad in my book. So I think Monaco is good.

Fix the class name before landing.
Comment 8 Pavel Feldman 2009-12-16 10:26:18 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/PropertiesSection.js
	M	WebCore/inspector/front-end/ResourceView.js
	M	WebCore/inspector/front-end/inspector.css
Committed r52203
Comment 9 Pavel Feldman 2009-12-16 10:27:44 PST 
(landed with all comments addressed)