|Summary:||Flakiness in WebSocket handshake console message|
|Product:||WebKit||Reporter:||Fumitoshi Ukai <ukai>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||ap, eric, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Fumitoshi Ukai 2009-12-16 00:02:10 PST
In chromium port, handshake-error.html may outputs 3 lines of CONSOLE MESSAGE: line 0: Unexpected response code:101
Comment 1 Fumitoshi Ukai 2009-12-16 00:20:15 PST
Created attachment 44952 [details] Fix flakiness in WebSocket handshake console message.
Comment 2 WebKit Review Bot 2009-12-16 00:25:06 PST
style-queue ran check-webkit-style on attachment 44952 [details] without any errors.
Comment 3 Alexey Proskuryakov 2009-12-16 21:16:55 PST
Comment on attachment 44952 [details] Fix flakiness in WebSocket handshake console message. r=me Is it be possible to make a reliable test for this? That would involve sending a large response that no reasonable implementation would coalesce into one didReceiveData call.
Comment 4 Fumitoshi Ukai 2009-12-16 22:19:22 PST
Committed r52234: <http://trac.webkit.org/changeset/52234>
Comment 5 Fumitoshi Ukai 2009-12-16 22:27:08 PST
(In reply to comment #3) > (From update of attachment 44952 [details]) > r=me > > Is it be possible to make a reliable test for this? That would involve sending > a large response that no reasonable implementation would coalesce into one > didReceiveData call. I think it would be difficult to make a reliable test. It must send several chunks for handshake response header and each chunk should be delivered as following order - first chunk. containing first line with bad response code, but not finished whole handshake message - bad response code, so it closes the SocketStreamHandle. - before didClose comes, it receives second chunk, which would be already queued while it is processing the first chunk.