Bug 32562

Summary: [V8] Generate trivial named property getters.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore JavaScriptAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jens, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32455    
Attachments:
Description Flags
Generate trivial named property getters, v1. eric: review+

Dimitri Glazkov (Google)
Reported 2009-12-15 09:04:38 PST
This is essentially a mirror patch to the one on bug 32455, only for named property getters. Small steps.
Attachments
Generate trivial named property getters, v1. (4.80 KB, patch)
2009-12-15 09:09 PST, Dimitri Glazkov (Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-12-15 09:09:12 PST
Created attachment 44881 [details] Generate trivial named property getters, v1.
WebKit Review Bot
Comment 2 2009-12-15 09:12:15 PST
style-queue ran check-webkit-style on attachment 44881 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-15 11:22:35 PST
Comment on attachment 44881 [details] Generate trivial named property getters, v1. toAtomicWebCoreStringWithNullCheck is the only confusing part. Looks good though!
Jens Alfke
Comment 4 2009-12-15 11:35:53 PST
Looks good.
Dimitri Glazkov (Google)
Comment 5 2009-12-15 11:56:03 PST
Landed as http://trac.webkit.org/changeset/52166.
Note You need to log in before you can comment on or make changes to this bug.