Bug 32548

Summary:

Allow custom memory allocation control for FormElementKey class

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	darin: review-, zoltan: commit-queue-

Zoltan Horvath

Reported 2009-12-15 04:20:08 PST

Inherits FormElementKey from FastAllocBase because it is instantiated by 'new' at: WebCore/dom/Document.h:170.

Attachments
proposed patch (1.04 KB, patch) 2009-12-15 04:21 PST, Zoltan Horvath	darin: review- zoltan: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2009-12-15 04:21:01 PST

Created attachment 44863 [details] proposed patch

WebKit Review Bot

Comment 2 2009-12-15 04:24:19 PST

style-queue ran check-webkit-style on attachment 44863 [details] without any errors.

Darin Adler

Comment 3 2009-12-15 08:23:00 PST

Comment on attachment 44863 [details] proposed patch The call to new in Document.h is a placement new, not a memory allocation new. I believe the static analyzer got it wrong.

Zoltan Horvath

Comment 4 2009-12-15 10:23:13 PST

Yes. I have to modify the analyzing rule a little bit. This bug is invalid.

Note You need to log in before you can comment on or make changes to this bug.