Summary: | Allow custom memory allocation control for WeakGCMap classes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Zoltan Horvath
2009-12-15 04:00:57 PST
Created attachment 44861 [details]
proposed patch
style-queue ran check-webkit-style on attachment 44861 [details] without any errors.
Comment on attachment 44861 [details]
proposed patch
HashMap is copyable, so I’m not sure why we would treat this as noncopyable. Please use FastAllocBase instead.
Created attachment 44887 [details]
updated to FastAllocBase
I chose Noncopyable because it is copied nowhere now, okay I filed the FastAllocBase-d version!
style-queue ran check-webkit-style on attachment 44887 [details] without any errors.
Comment on attachment 44887 [details] updated to FastAllocBase Clearing flags on attachment: 44887 Committed r52171: <http://trac.webkit.org/changeset/52171> All reviewed patches have been landed. Closing bug. |