Bug 32547

Summary: Allow custom memory allocation control for WeakGCMap classes
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
darin: review-
updated to FastAllocBase none

Zoltan Horvath
Reported 2009-12-15 04:00:57 PST
Inherits WeakGCMap from Noncopyable because it is instantiated by 'new' at: WebCore/dom/Document.cpp:512 and don't need to be copyable.
Attachments
proposed patch (1.20 KB, patch)
2009-12-15 04:06 PST, Zoltan Horvath 		darin: review-
DetailsFormatted DiffDiff
updated to FastAllocBase (1.17 KB, patch)
2009-12-15 10:34 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-12-15 04:06:21 PST
Created attachment 44861 [details] proposed patch
WebKit Review Bot
Comment 2 2009-12-15 04:08:37 PST
style-queue ran check-webkit-style on attachment 44861 [details] without any errors.
Darin Adler
Comment 3 2009-12-15 08:30:05 PST
Comment on attachment 44861 [details] proposed patch HashMap is copyable, so I’m not sure why we would treat this as noncopyable. Please use FastAllocBase instead.
Zoltan Horvath
Comment 4 2009-12-15 10:34:08 PST
Created attachment 44887 [details] updated to FastAllocBase I chose Noncopyable because it is copied nowhere now, okay I filed the FastAllocBase-d version!
WebKit Review Bot
Comment 5 2009-12-15 10:34:50 PST
style-queue ran check-webkit-style on attachment 44887 [details] without any errors.
WebKit Commit Bot
Comment 6 2009-12-15 13:55:15 PST
Comment on attachment 44887 [details] updated to FastAllocBase Clearing flags on attachment: 44887 Committed r52171: <http://trac.webkit.org/changeset/52171>
WebKit Commit Bot
Comment 7 2009-12-15 13:55:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.