Bug 32547

Summary: Allow custom memory allocation control for WeakGCMap classes
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
proposed patch
darin: review-
updated to FastAllocBase none

Description Zoltan Horvath 2009-12-15 04:00:57 PST
Inherits WeakGCMap from Noncopyable because it is instantiated by 'new' at: WebCore/dom/Document.cpp:512 and don't need to be copyable.
Comment 1 Zoltan Horvath 2009-12-15 04:06:21 PST
Created attachment 44861 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-15 04:08:37 PST
style-queue ran check-webkit-style on attachment 44861 [details] without any errors.
Comment 3 Darin Adler 2009-12-15 08:30:05 PST
Comment on attachment 44861 [details]
proposed patch

HashMap is copyable, so I’m not sure why we would treat this as noncopyable. Please use FastAllocBase instead.
Comment 4 Zoltan Horvath 2009-12-15 10:34:08 PST
Created attachment 44887 [details]
updated to FastAllocBase

I chose Noncopyable because it is copied nowhere now, okay I filed the FastAllocBase-d version!
Comment 5 WebKit Review Bot 2009-12-15 10:34:50 PST
style-queue ran check-webkit-style on attachment 44887 [details] without any errors.
Comment 6 WebKit Commit Bot 2009-12-15 13:55:15 PST
Comment on attachment 44887 [details]
updated to FastAllocBase

Clearing flags on attachment: 44887

Committed r52171: <http://trac.webkit.org/changeset/52171>
Comment 7 WebKit Commit Bot 2009-12-15 13:55:19 PST
All reviewed patches have been landed.  Closing bug.