|Summary:||Move Credential handling out into a separate module|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, commit-queue, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Eric Seidel (no email) 2009-12-14 15:43:08 PST
Move Credential handling out into a separate module bugzilla.py does too much. Lets start by moving credential handling out into its own module. It was already some static functions (which made it harder to test too).
Comment 2 WebKit Review Bot 2009-12-14 21:04:55 PST
style-queue ran check-webkit-style on attachment 44826 [details] without any errors.
Comment 3 Adam Barth 2009-12-14 21:46:36 PST
Comment on attachment 44826 [details] Patch This looks great. Love the tests. However, we should normalize to using _ before private member variable names. :)
Comment 4 WebKit Commit Bot 2009-12-14 22:01:02 PST
Comment on attachment 44826 [details] Patch Clearing flags on attachment: 44826 Committed r52135: <http://trac.webkit.org/changeset/52135>
Comment 5 WebKit Commit Bot 2009-12-14 22:01:08 PST
All reviewed patches have been landed. Closing bug.