Summary: | Web Inspector: Extract WebInspector.Section from WebInspector.PropertiesSection | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2009-12-14 09:46:57 PST
Created attachment 44806 [details]
patch
Comment on attachment 44806 [details]
patch
This might conflict with Pavel's recent changes for keyboard focus.
Comment on attachment 44806 [details]
patch
Rejecting patch 44806 from commit-queue.
Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 1
Last 500 characters of output:
e.gypi
Hunk #1 succeeded at 3700 (offset 5 lines).
patching file WebCore/WebCore.vcproj/WebCore.vcproj
Hunk #1 succeeded at 42620 (offset 14 lines).
patching file WebCore/inspector/front-end/PropertiesSection.js
Hunk #2 FAILED at 29.
1 out of 2 hunks FAILED -- saving rejects to file WebCore/inspector/front-end/PropertiesSection.js.rej
patching file WebCore/inspector/front-end/Section.js
patching file WebCore/inspector/front-end/WebKit.qrc
patching file WebCore/inspector/front-end/inspector.html
I'll land manually or let Alexander update the patch. Created attachment 44860 [details]
patch (merged)
style-queue ran check-webkit-style on attachment 44860 [details] without any errors.
Comment on attachment 44860 [details] patch (merged) Clearing flags on attachment: 44860 Committed r52149: <http://trac.webkit.org/changeset/52149> All reviewed patches have been landed. Closing bug. |