Bug 32523 - Web Inspector: Extract WebInspector.Section from WebInspector.PropertiesSection
Summary: Web Inspector: Extract WebInspector.Section from WebInspector.PropertiesSection
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-14 09:46 PST by Alexander Pavlov (apavlov)
Modified: 2009-12-15 03:29 PST (History)
9 users (show)

See Also:

patch (11.28 KB, patch)
2009-12-14 10:00 PST, Alexander Pavlov (apavlov)
timothy: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (merged) (11.34 KB, patch)
2009-12-15 03:11 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2009-12-14 09:46:57 PST
A more generic section than WebInspector.PropertiesSection (not containing a list) is necessary, to enable the Audits panel to show audit results.
This is the second bit of the Audits panel submission.
Comment 1 Alexander Pavlov (apavlov) 2009-12-14 10:00:37 PST
Created attachment 44806 [details]
Comment 2 Timothy Hatcher 2009-12-14 13:01:30 PST
Comment on attachment 44806 [details]

This might conflict with Pavel's recent changes for keyboard focus.
Comment 3 WebKit Commit Bot 2009-12-14 14:38:40 PST
Comment on attachment 44806 [details]

Rejecting patch 44806 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 1
Last 500 characters of output:
Hunk #1 succeeded at 3700 (offset 5 lines).
patching file WebCore/WebCore.vcproj/WebCore.vcproj
Hunk #1 succeeded at 42620 (offset 14 lines).
patching file WebCore/inspector/front-end/PropertiesSection.js
Hunk #2 FAILED at 29.
1 out of 2 hunks FAILED -- saving rejects to file WebCore/inspector/front-end/PropertiesSection.js.rej
patching file WebCore/inspector/front-end/Section.js
patching file WebCore/inspector/front-end/WebKit.qrc
patching file WebCore/inspector/front-end/inspector.html
Comment 4 Pavel Feldman 2009-12-14 14:41:11 PST
I'll land manually or let Alexander update the patch.
Comment 5 Alexander Pavlov (apavlov) 2009-12-15 03:11:04 PST
Created attachment 44860 [details]
patch (merged)
Comment 6 WebKit Review Bot 2009-12-15 03:11:57 PST
style-queue ran check-webkit-style on attachment 44860 [details] without any errors.
Comment 7 WebKit Commit Bot 2009-12-15 03:29:19 PST
Comment on attachment 44860 [details]
patch (merged)

Clearing flags on attachment: 44860

Committed r52149: <http://trac.webkit.org/changeset/52149>
Comment 8 WebKit Commit Bot 2009-12-15 03:29:24 PST
All reviewed patches have been landed.  Closing bug.