RESOLVED FIXED Bug 32523
Web Inspector: Extract WebInspector.Section from WebInspector.PropertiesSection 
https://bugs.webkit.org/show_bug.cgi?id=32523
Summary Web Inspector: Extract WebInspector.Section from WebInspector.PropertiesSection
Alexander Pavlov (apavlov)
Reported 2009-12-14 09:46:57 PST
A more generic section than WebInspector.PropertiesSection (not containing a list) is necessary, to enable the Audits panel to show audit results. This is the second bit of the Audits panel submission.
Attachments
patch (11.28 KB, patch)
2009-12-14 10:00 PST, Alexander Pavlov (apavlov) 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
patch (merged) (11.34 KB, patch)
2009-12-15 03:11 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2009-12-14 10:00:37 PST
Created attachment 44806 [details] patch
Timothy Hatcher
Comment 2 2009-12-14 13:01:30 PST
Comment on attachment 44806 [details] patch This might conflict with Pavel's recent changes for keyboard focus.
WebKit Commit Bot
Comment 3 2009-12-14 14:38:40 PST
Comment on attachment 44806 [details] patch Rejecting patch 44806 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 1 Last 500 characters of output: e.gypi Hunk #1 succeeded at 3700 (offset 5 lines). patching file WebCore/WebCore.vcproj/WebCore.vcproj Hunk #1 succeeded at 42620 (offset 14 lines). patching file WebCore/inspector/front-end/PropertiesSection.js Hunk #2 FAILED at 29. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/inspector/front-end/PropertiesSection.js.rej patching file WebCore/inspector/front-end/Section.js patching file WebCore/inspector/front-end/WebKit.qrc patching file WebCore/inspector/front-end/inspector.html
Pavel Feldman
Comment 4 2009-12-14 14:41:11 PST
I'll land manually or let Alexander update the patch.
Alexander Pavlov (apavlov)
Comment 5 2009-12-15 03:11:04 PST
Created attachment 44860 [details] patch (merged)
WebKit Review Bot
Comment 6 2009-12-15 03:11:57 PST
style-queue ran check-webkit-style on attachment 44860 [details] without any errors.
WebKit Commit Bot
Comment 7 2009-12-15 03:29:19 PST
Comment on attachment 44860 [details] patch (merged) Clearing flags on attachment: 44860 Committed r52149: <http://trac.webkit.org/changeset/52149>
WebKit Commit Bot
Comment 8 2009-12-15 03:29:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.