Bug 32496

Summary: Switch remaining cases of string construction to use StringBuilder.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2009-12-13 14:18:18 PST
Builds strings using a vector rather than using string append / addition.
Attachments
The patch (28.50 KB, patch)
2009-12-13 14:26 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-12-13 14:26:15 PST
Created attachment 44765 [details] The patch ~0% performance impact (possible slight, slight progression)
WebKit Review Bot
Comment 2 2009-12-13 14:31:22 PST
style-queue ran check-webkit-style on attachment 44765 [details] without any errors.
Sam Weinig
Comment 3 2009-12-13 14:44:35 PST
Comment on attachment 44765 [details] The patch > Index: JavaScriptCore/runtime/StringBuilder.h > =================================================================== > --- JavaScriptCore/runtime/StringBuilder.h (revision 0) > +++ JavaScriptCore/runtime/StringBuilder.h (revision 0) > @@ -0,0 +1,64 @@ > +/* ... > + } > +}; > + > +}; This ; is not necessary.
Eric Seidel (no email)
Comment 4 2009-12-28 23:38:42 PST
Looks like this was landed as r52075. Closing.
Note You need to log in before you can comment on or make changes to this bug.