Bug 32491

Summary: [Qt] The test tst_QWebPage::inputMethods(QWebView) fails
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit QtAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32216    
Attachments:
Description Flags
Update the test to expect the correct behavior
none
Update the test to expect the correct behavior none

Benjamin Poulain
Reported 2009-12-13 10:29:47 PST
The autotest tst_QWebPage::inputMethods(QWebView) is failing: FAIL! : tst_QWebPage::inputMethods(QWebView) Compared values are not the same Actual (QString("-webkit-serif")): -webkit-serif Expected (font.family()): Times New Roman Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)] FAIL! : tst_QWebPage::inputMethods(QGraphicsWebView) Compared values are not the same Actual (QString("-webkit-serif")): -webkit-serif Expected (font.family()): Times New Roman Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)]
Attachments
Update the test to expect the correct behavior (1.67 KB, patch)
2009-12-14 06:40 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Update the test to expect the correct behavior (1.67 KB, patch)
2009-12-14 06:41 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2009-12-14 06:40:12 PST
Created attachment 44792 [details] Update the test to expect the correct behavior
Andreas Kling
Comment 2 2009-12-14 06:41:32 PST
Created attachment 44793 [details] Update the test to expect the correct behavior Same patch with a minor tweak to the changelog entry.
WebKit Review Bot
Comment 3 2009-12-14 06:48:46 PST
style-queue ran check-webkit-style on attachment 44793 [details] without any errors.
Simon Hausmann
Comment 4 2009-12-14 08:26:46 PST
Comment on attachment 44793 [details] Update the test to expect the correct behavior r=me, thanks!
WebKit Commit Bot
Comment 5 2009-12-14 12:35:39 PST
Comment on attachment 44793 [details] Update the test to expect the correct behavior Clearing flags on attachment: 44793 Committed r52110: <http://trac.webkit.org/changeset/52110>
WebKit Commit Bot
Comment 6 2009-12-14 12:35:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.