Bug 32468

Summary: [bzt] Add AbstractPatchSequencingCommand to remove redundant code
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 32467    
Bug Blocks: 32469    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2009-12-12 01:32:46 PST
Redundant code is bad. This patch moves us towards more declarative commands.
Attachments
Patch (7.60 KB, patch)
2009-12-12 01:33 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-12 01:33:45 PST
Created attachment 44735 [details] Patch
Eric Seidel (no email)
Comment 2 2009-12-14 16:23:10 PST
Comment on attachment 44735 [details] Patch I'm confused by this line: 126 return step_sequence, step_sequence.options()
Eric Seidel (no email)
Comment 3 2009-12-14 21:22:24 PST
Comment on attachment 44735 [details] Patch So I don't understand why options need to be returned separately from the sequence, but otherwise this looks fine. We really need to kill all these "show_in_main_help = false" at some point.
Adam Barth
Comment 4 2009-12-14 21:37:51 PST
Good point. I'll fix that at the end.
Adam Barth
Comment 5 2009-12-14 21:38:18 PST
Comment on attachment 44735 [details] Patch Clearing flags on attachment: 44735 Committed r52132: <http://trac.webkit.org/changeset/52132>
Adam Barth
Comment 6 2009-12-14 21:38:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.