Summary: | build-webkit: Add --inspector-frontend flag to copy inspector front-end changes to the built framework | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, bweinstein, commit-queue, eric, jmalonzo, mrowe, timothy, webkit.review.bot, zoltan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Daniel Bates
2009-12-11 23:23:27 PST
Note building with Xcode works fine. Created attachment 44726 [details]
Patch
Briefly read through the Qt and GTK build files, but I am unclear what the default installation directory for the inspector front-end files is for the Qt and GTK builds. In particular for the Windows platform. For reference, on my Ubuntu Qt build it defaults to /usr/share. I'll try reading through these files again. Does anybody know offhand?
Created attachment 44742 [details]
Patch
Minor stylistic change. Changed ordering of variables $sourceInspectorPath and $inspectorResourcesDirPath in subroutine copyInspectorFrontendFiles.
Spoke to Timothy on IRC, and this patch should be sufficient to land. That is, the assumptions for the Qt and GTK builds are not unreasonable. Optionally, the user can set the environment variable WebKitInspectorResourcesDir to specify where the built inspector front-end files are located.
style-queue ran check-webkit-style on attachment 44742 [details] without any errors.
Comment on attachment 44742 [details] Patch Clearing flags on attachment: 44742 Committed r52393: <http://trac.webkit.org/changeset/52393> All reviewed patches have been landed. Closing bug. |