Bug 3246

Summary:

HSPACE and VSPACE attributes are ignored in APPLET element

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

DOM

Assignee:

Dave Hyatt <hyatt>

Status:

VERIFIED FIXED

Severity:

Normal

Priority:

Version:

412

Hardware:

All

OS:

All

Attachments:

Description	Flags
test cases	none
Add support for HSPACE and VSPACE on APPLET	darin: review+

Dave Hyatt

Reported 2005-06-01 16:16:18 PDT

4/26/05 11:17 AM Chris Petersen: * SUMMARY Both VSPACE and HSPACE attributes are ignored when used in a APPLET element * STEPS TO REPRODUCE 1. Launch Safari 2.0 (v412) under Tiger 8A428 (Java enabled) 2. Open test case "vspace_applet.html" in Safari. 3. Notice the first APPLET has a VSPACE value of "100" pixels but no whitespace is rendered above or below this applet. 4. Open this same test case in Firefox. Notice whitespace is rendered above and below the FIRST applet. 5. Open test case "hspace_applet.html" in Safari. 6. Notice the first APPLET has a HSPACE value of "100" pixels but no whitespace is rendered on either side of the applet. 7. Open this same test case in Firefox. Notice whitespace is rendered on left and right side of the FIRST applet. * REGRESSION No, these attributes were not supported by Safari 1.2 either * NOTES We need to support these attributes when used with a APPLET element. I have attached a .zip file that contains hspace_applet.html, vspace_applet.html, and applet code.

Attachments
test cases (16.67 KB, application/zip) 2005-06-15 00:57 PDT, Toby Peterson	no flags	Details
Add support for HSPACE and VSPACE on APPLET (1.20 KB, patch) 2005-06-15 02:18 PDT, Niels Leenheer (HTML5test)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2005-06-01 16:16:43 PDT

Apple Bug: rdar://4099440/

Toby Peterson

Comment 2 2005-06-15 00:57:50 PDT

Created attachment 2350 [details] test cases

Niels Leenheer (HTML5test)

Comment 3 2005-06-15 02:18:46 PDT

Created attachment 2354 [details] Add support for HSPACE and VSPACE on APPLET This patch adds support for the HSPACE and VSPACE attributes on the APPLET element.

Joost de Valk (AlthA)

Comment 4 2005-06-15 02:23:20 PDT

patch works for me.

Darin Adler

Comment 5 2005-06-18 16:55:01 PDT

Comment on attachment 2354 [details] Add support for HSPACE and VSPACE on APPLET Although Dave Hyatt and I discussed better factoring of this code, it seems fine to add this now and worry further about factoring later. r=me

Chris Petersen

Comment 6 2005-06-18 21:44:39 PDT

Excellent ! Verified fixed with latest TOT Webkit (06/18). Tested under 10.4.1 (B15).

Joost de Valk (AlthA)

Comment 7 2005-07-13 23:02:57 PDT

Fixed in 10.4.2

Note You need to log in before you can comment on or make changes to this bug.