Bug 32455

Summary: [V8] Indexers and named propery getters should be generated
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore JavaScriptAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 32562, 32569, 32637, 32996    
Bug Blocks: 32630    
Attachments:
Description Flags
Generate bindings for trivial indexers.
none
Generate bindings for trivial indexers.
dglazkov: commit-queue-
An example of new generated file. none

Dimitri Glazkov (Google)
Reported 2009-12-11 15:37:09 PST
V8 bindings for indexers and named property getters could be easily generated, thus avoiding the maintenance burden when adding new IDLs.
Attachments
Generate bindings for trivial indexers. (8.94 KB, patch)
2009-12-11 15:39 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Generate bindings for trivial indexers. (9.26 KB, patch)
2009-12-14 13:32 PST, Dimitri Glazkov (Google) 		dglazkov: commit-queue-
DetailsFormatted DiffDiff
An example of new generated file. (3.76 KB, text/plain)
2009-12-14 14:11 PST, Dimitri Glazkov (Google) 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-12-11 15:39:46 PST
Created attachment 44714 [details] Generate bindings for trivial indexers.
WebKit Review Bot
Comment 2 2009-12-11 15:41:29 PST
style-queue ran check-webkit-style on attachment 44714 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-11 17:35:20 PST
Comment on attachment 44714 [details] Generate bindings for trivial indexers. Looks sane, but could we make the perl more readable? Like by putting this new code in a well-named sub-routine?
Dimitri Glazkov (Google)
Comment 4 2009-12-11 19:31:18 PST
Sure, sounds good. Most of this should go away anyway, once I switch over to use toV8(...) type resolution a-la JSC-land. This is just a first step :) I am going abarth on these bindings!
Dimitri Glazkov (Google)
Comment 5 2009-12-11 19:32:28 PST
Comment on attachment 44714 [details] Generate bindings for trivial indexers. I'll prettify the Perl code and repost.
Dimitri Glazkov (Google)
Comment 6 2009-12-14 13:32:03 PST
Created attachment 44817 [details] Generate bindings for trivial indexers.
Eric Seidel (no email)
Comment 7 2009-12-14 13:59:13 PST
Comment on attachment 44817 [details] Generate bindings for trivial indexers. It would be nice to see an example of the new generated code. But this looks OK as far as I can tell. Are you sure we have tests covering index getters for all these?
Dimitri Glazkov (Google)
Comment 8 2009-12-14 14:11:38 PST
Created attachment 44822 [details] An example of new generated file. Here's an example of the new generated output. Look for "setCollectionIndexerGetter" added to ConfigureV8CSSRuleListTemplate. It used to be set in a long case statement inside V8DOMWrapper:getTemplate.
Dimitri Glazkov (Google)
Comment 9 2009-12-14 15:25:26 PST
Landed as http://trac.webkit.org/changeset/52120.
Dimitri Glazkov (Google)
Comment 10 2009-12-15 08:55:36 PST
I am going to use this as a master bug for V8 getter generation.
Eric Seidel (no email)
Comment 11 2009-12-28 23:37:53 PST
Comment on attachment 44817 [details] Generate bindings for trivial indexers. Clearing my r+ on this obsolete patch.
Dimitri Glazkov (Google)
Comment 12 2009-12-30 08:57:29 PST
All hand-coded configuring indexer or named property handling is gone.
Note You need to log in before you can comment on or make changes to this bug.