Bug 32429

Summary:

Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.whatwg.org/specs/web-apps/current-work/multipage/number-state.html#attr-input-accept

Bug Depends on:

Bug Blocks:

19264, 32473

Attachments:

Description	Flags
Proposed patch	none

Description Kent Tamura 2009-12-11 06:39:31 PST

ChromeClient::runOpenPanel() implementation should be able to refer 'accept' attribute to support it.

Comment 1 Kent Tamura 2009-12-11 06:49:22 PST

Created attachment 44685 [details]
Proposed patch

Comment 2 WebKit Review Bot 2009-12-11 06:53:53 PST

style-queue ran check-webkit-style on attachment 44685 [details] without any errors.

Comment 3 Darin Fisher (:fishd, Google) 2009-12-11 09:25:35 PST

Comment on attachment 44685 [details]
Proposed patch

> +++ b/WebCore/rendering/RenderFileUploadControl.cpp
...
> +String RenderFileUploadControl::acceptTypes()
> +{
> +    HTMLInputElement* input = static_cast<HTMLInputElement*>(node());
> +    return input->accept();
> +}

nit: no need for the input variable, just do:

  return static_cast<HTMLInputElement*>(node())->accept();

Otherwise, R=me

Comment 4 Kent Tamura 2009-12-11 10:16:35 PST

(In reply to comment #3)

Thank you for reviewing.

> nit: no need for the input variable, just do:
> 
>   return static_cast<HTMLInputElement*>(node())->accept();
> 
> Otherwise, R=me

Fixed it, and commit manually as r52003.